search

PlatinumTeam / PlatinumQuest

PQ HERe
https://marbleblast.com
MIT License
21 stars 7 forks source link

New sound effects for Bubble and Mega Marble (and more typo fixes) #7

Closed main-gi closed 3 years ago

main-gi commented 3 years ago

The Bubble just uses the Super Bounce SFX, and the Mega Marble uses the Super Jump SFX on use. These new sound effects are by me.

main-gi commented 3 years ago

The 5 "add files via upload" and "merge pull request" were just to sync my own fork with the master fork, by the way.

adierking commented 3 years ago

Thanks for submitting this!

I need to close this for a couple reasons, though: 1) the "add files via upload" commits duplicate changes we already have, and 2) there's too many different things going on here. It's much easier for us to manage things when each pull request only does one logical thing; adding new sounds and changing typos are both welcome but not related to each other. So please open a new pull request for the sounds and another one for the typos.

Please refer to my comment here for information on how to correctly make pull requests.

main-gi commented 3 years ago

Sorry, 1) happened because I thought I had to update my own fork with the master fork (since I'm using GitHub's lacking online UI), and 2) because I was updating my own fork and wasn't sure what to do about the pull request automatically updating itself.

Guess I had to learn git itself one of these days. Sigh. Yeah, I'll do it.