search

Platoniq / decidim-module-navigation_maps

A module for Decidim that adds sensible areas in a map
GNU Affero General Public License v3.0
7 stars 10 forks source link

Refactoring of the javascript that deals with the map view and the editor. #2

Closed davidbeig closed 5 years ago

davidbeig commented 5 years ago

Continue the refactoring started by @microstudi on admin/navigation_maps and navigation_maps.

Also this PR fixes some problems with the inheritance of the ApplicationController and the views for the content_block_settings_form.

codecov-io commented 5 years ago

Codecov Report

Merging #2 into master will decrease coverage by 0.74%. The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage      63%   62.25%   -0.75%     
==========================================
  Files          17       17              
  Lines         200      204       +4     
==========================================
+ Hits          126      127       +1     
- Misses         74       77       +3
Impacted Files Coverage Δ
...ontent_blocks/navigation_map_settings_form_cell.rb 0% <0%> (ø) :arrow_up:
lib/decidim/navigation_maps/engine.rb 100% <100%> (ø) :arrow_up:
...dim/navigation_maps/admin/blueprints_controller.rb 95% <100%> (ø) :arrow_up:
...im/navigation_maps/admin/application_controller.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6818089...580939e. Read the comment docs.

microstudi commented 5 years ago

@codecov-io nice eh? @dabign