search

Platymemo / alaskanativecraft

Alaska Native Craft is a mod looking to bring Alaska Native cultures to Minecraft!
Creative Commons Zero v1.0 Universal
9 stars 12 forks source link

[BUG]Harpoons can get trident enchants that don't work #13

Closed varencilator closed 3 years ago

varencilator commented 3 years ago

Describe the bug You can enchant harpoons with trident specific enchants which do not appear to work on the harpoon

To Reproduce Steps to reproduce the behavior:

  1. Enchant harpoon with Channeling, Loyalty, or Riptide
  2. Try to use the enchantments
  3. They don't work. Loyalty doesn't return, Channeling doesn't summon lightning, Riptide (in water) will propel you but not as far as the harpoon.

Expected behavior Either it works like a trident or shouldn't be possible to get those enchantments on the harpoon. I prefer the latter to make them specifically different.

Mod Versions (please complete the following information):

Platymemo commented 3 years ago

Ahh, I will work on these today. Sorry I didn't get to this sooner, just finished up finals week haha.

varencilator commented 3 years ago

Don't stress it, hope you did well on your finals :)

Platymemo commented 3 years ago

Fixed with d3c8600. I've decided to let them work like a trident, for now. I've gotta think long and hard about other ways for them to stand out. Also, I'll probably change the riptide functionality later to something else.