search

Platymemo / alaskanativecraft

Alaska Native Craft is a mod looking to bring Alaska Native cultures to Minecraft!
Creative Commons Zero v1.0 Universal
9 stars 12 forks source link

[BUG] Fortune Enchantment Mixin is buggy #7

Closed BrekiTomasson closed 3 years ago

BrekiTomasson commented 3 years ago

Your LuckEnchantmentMixin.java has faulty logic in it. With your mod loaded, I am unable to /enchant playername fortune 3.

    @Override
    public boolean isAcceptableItem(ItemStack itemStack) {
        if (this.type == EnchantmentTarget.DIGGER) {
            return itemStack.getItem() == AlaskaNativeItems.ULU;
        }
        return super.isAcceptableItem(itemStack);
    }

If you follow the logic in your code, it's basically going: "This is a pickaxe! A pickaxe is a Digger! A pickaxe is not an Ulu... So let's return false!"

Platymemo commented 3 years ago

Fixed in 1.1.0, (by removing it all together)