search

PlayCover / PlayTools

Tools for keymapping, dynamic resolution, and more
GNU Affero General Public License v3.0
71 stars 56 forks source link

Add toggle for scroll wheel #132

Closed y-tai closed 11 months ago

y-tai commented 1 year ago

In Genshin Impact, the scroll wheel may cause some bugs:

  1. If you use the scroll wheel to the maximum, it will trigger an unexpected camera lock. As the video says, the character moves but the camera locks.
  2. When playing games with the touchpad, sometimes I will be stuck in a zoom-only perspective, and at this time, you can no longer rotate the camera but only zoom-in & zoom-out. After turning off the wheel mapping, the above bugs do not reappear, so I added a toggle to control the scroll wheel mapping. Another PR in playcover repo: https://github.com/PlayCover/PlayCover/pull/1215

After investigating, I found that this is related to inertial scrolling in Mac, but I find no solution to fix this issue in code.:(

https://github.com/PlayCover/PlayTools/assets/21299239/25926895-3a5e-4bb9-8398-2553f2d43f12

RellikJaeger commented 1 year ago

Can I toggle the entire keymap? The keymap bug also exists in the game chat keyboard typing. It would be better to have a manual toggle shortcut to disable the keymap temporarily during text input typing.

MEMORIEmusic commented 1 year ago

Can I toggle the entire keymap? The keymap bug also exists in the game chat keyboard typing. It would be better to have a manual toggle shortcut to disable the keymap temporarily during text input typing.

This is a known bug with smart keymapping. To be able to type in chat, right click genshin -> settings -> disable Smart Keymapping

RellikJaeger commented 1 year ago

Can I toggle the entire keymap? The keymap bug also exists in the game chat keyboard typing. It would be better to have a manual toggle shortcut to disable the keymap temporarily during text input typing.

This is a known bug with smart keymapping. To be able to type in chat, right click genshin -> settings -> disable Smart Keymapping

Thanks for the quick fix! Worked like a charm.