PlayEveryWare / eos_plugin_for_unity

Repository for PlayEveryWare's EOS Plugin for Unity, bringing the functionality of Epic Online Services to the Unity Game Engine.
https://eospluginforunity.playeveryware.com
288 stars 56 forks source link

Syntax errors in release #505

Closed jcx closed 9 months ago

jcx commented 9 months ago

Describe the bug EOSManager - lines 1010 to 1015 are bugged EpicOnlineServicesConfigEditor - line 621 wrong use of string instead of char

To Reproduce Steps to reproduce the behavior: import the thing to unity

Expected behavior no syntax errors

paulhazen commented 9 months ago

Hi @jcx,

Thanks for reaching out! After taking a look at those lines I have a few follow-up questions, and some suggestions.

For starters - are you using a upm release, or are you building a release from the stable branch?

Syntax Errors in EOSManager

Lines 1010-1015 in EOSManager.cs in the stable branch are:

var copyUserTokenOptions = new Epic.OnlineServices.Auth.CopyUserAuthTokenOptions();
var result = EOSAuthInterface.CopyUserAuthToken(ref copyUserTokenOptions, callbackInfo.LocalUserId, out Token? userAuthToken);

connectLoginOptions.Credentials = new Epic.OnlineServices.Connect.Credentials
{
    Token = userAuthToken.Value.AccessToken,

Can you clarify what the specific syntax errors are? I'm not seeing them.

Syntax Errors in EpicOnlineServicesConfigEditor

As for EpicOnlineServicesConfigEditor, I suspect that you might be getting a warning from your IDE, because according to the documentation for the split function, providing a string is acceptable. In this particular instance, it might make more sense to use a char instead, but either one is acceptable (which is why I suspect you're just getting a warning).

Many apologies if you're already aware of this, but I thought I'd mention it as well: If you are using Visual Studio, within the "Error" window panel there is an option to show either build errors, intellisense errors, or both.

image

The default is to use both, and sometimes Intellisense flags things as errors (usually warnings) when they actually aren't. Is there a chance this could explain your experience?

Curious to know what the syntax errors are in EOSManager.

jcx commented 9 months ago

Hi, it's from com.playeveryware.eos-3.0.3.tgz downloaded from https://github.com/PlayEveryWare/eos_plugin_for_unity/releases

here's the problem in EOSManager.cs image

and here's the 621 in EpicOnlineServiceConfigEditor image

jcx commented 9 months ago

... so I've checked and found out the error is in both repos in stable and master branch, so i am kinda confused by your response about EOSManager

image

image

jcx commented 9 months ago

i am curious if you checked your code locally or on the github ... and if you'd care to import that 3.0.3 package to unity ... it might be completely my fault but it's very unlikely that unity will show red syntax errors which won't let you even import and when i fix them everything looks fine

arthur740212 commented 9 months ago

The steam syntax part looks like this issue https://github.com/PlayEveryWare/eos_plugin_for_unity/issues/473 This is because of the .NET version discrepancy across different Unity versions. Which Unity and .NET version were you using? That could possibly be the reason.

paulhazen commented 9 months ago

Hi @jcx. Just to follow up - can you confirm whether the Unity / .NET version discrepancy is not the source of the problem?

paulhazen commented 9 months ago

I'm closing this issue for lack of activity. If you still are experiencing this issue, feel free to re-open the issue with additional context.