PlayEveryWare / eos_plugin_for_unity

Repository for PlayEveryWare's EOS Plugin for Unity, bringing the functionality of Epic Online Services to the Unity Game Engine.
https://eospluginforunity.playeveryware.com
MIT License
266 stars 46 forks source link

Bug with "Session" class wrapper from PlayEveryWare, variable "NumConnections" stuck at 1 no matter how many players join #741

Open superrafyYT opened 3 weeks ago

superrafyYT commented 3 weeks ago

Describe the bug When a player creates a session, and another players joins, the third joining still see the "NumConnections" still at 1 instead of 2

To Reproduce Steps to reproduce the behavior:

  1. Create a session
  2. Join a session with 2 clients
  3. Find session with a 3rd client
  4. 3rd client sees the session with apparently just 1 connection/player

Expected behavior I guess it should show 2 in this example rather than 1

Desktop (please complete the following information):

Smartphone (please complete the following information):

All clients use these login type: image

WispyMouse commented 2 weeks ago

Ahoy @superrafyYT! Thank you for creating this issue.

We investigated the Sessions sample, where this is primarily used, and found some things about the C sample it was based off of for the Epic Online Services SDK. While the C# sample in this repository mostly has parity with the SDK's C sample, it is clear that there are flaws in the maintenance of the Session's information. For example, there isn't currently a mechanism for updating members of the Session with information about how many people are in the Session, or when certain parameters change. This results in everyone's client thinking there's only one member of the session, which is definitely not always true!

Our team is going to look in to how to improve this experience and the Sessions object. It's an objective of ours to find a solution for maintaining this NumConnections number properly, as well as other elements of the Session. We'll get back to you after we've made the appropriate changes.

superrafyYT commented 2 weeks ago

alright, thanks!

WispyMouse commented 2 weeks ago

Ahoy! I wanted to update you on this.

The Sessions Interface does not implement any way to inform members of the session that someone has joined or left, if they hadn't joined through the social interface. Our team is currently working on a rework of the Sessions sample that would include Peer 2 Peer messaging. The goal is to create a sessions sample that implements a message upon a user joining, leaving, or the session being modified, that would key everyone to update their session's information.

We'll keep you updated on when this makes its way in to a place you can pull from!