PlayFab / PlayFabMultiplayerUnreal

PlayFab Online Subsystem Plugin for Unreal Engine
https://learn.microsoft.com/en-us/gaming/playfab/features/multiplayer/networking/party-unreal-engine-oss-overview
39 stars 35 forks source link

PF OSS not creating a socketsubsystem if marketplace plugin installed? #33

Closed dylanh724 closed 1 year ago

dylanh724 commented 1 year ago

Unless you just so happen to wander across a blue moon in your Discord from non-staff on a very specific date from just another PF user from a 2022 post, absolutely no one would know that if you have the marketplace plugin, socketsubsystem isn't created.

How would anyone possibly know? Anytime someone has questions, PF staff vaguely redirects us to UE4's OSS docs; as if they used identical naming conventions, namespaces and transparently have strange init issues like the one mentioned above. Even your latest n greatest matchmaking docs start you with the Multiplayer SDK then 1/2 way tell you to use the OSS for event callbacks (rather than polling); in theory, everyone should eventually encounter this bug.

Related to many of the other issues posted here,

[ https://github.com/PlayFab/PlayFabMultiplayerUnreal/issues/32 , https://github.com/PlayFab/PlayFabMultiplayerUnreal/issues/30 , https://github.com/PlayFab/PlayFabMultiplayerUnreal/issues/31 , https://github.com/PlayFab/PlayFabMultiplayerUnreal/issues/28 , https://github.com/PlayFab/PlayFabMultiplayerUnreal/issues/27 , ]

it all funnels down to you have NO OSS docs. No one -- not even staff -- seems to know how to use the PF OSS alongside the "core sdk" multiplayer::matchmaking api. This isn't a 1:1 interface implementation; it's wildly different.

There's no inline docs, no online docs for this. Who is responsible for technical docs for the OSS so that I may directly contact them? No one seems to take responsibility.


This could be related: https://github.com/PlayFab/PlayFabMultiplayerUnreal/issues/22 -- however, posted months ago with minimal contributor activity.

yuehanlin commented 1 year ago

Thank you for reporting that.

This is the temporary solution to resolve it in https://github.com/PlayFab/PlayFabMultiplayerUnreal/blob/main/Source/Private/OnlineSubsystemPlayFab.cpp. Change line 107 fromTSharedPtr<IPlugin> SocketsPlugin = IPluginManager::Get().FindPlugin(TEXT("PlayFab")); to TSharedPtr<IPlugin> SocketsPlugin = IPluginManager::Get().FindPlugin(TEXT("PlayFabParty")); .

We've filed a bug, and will update the new release as soon as possible.

yuehanlin commented 1 year ago

Solution updated in the latest release 2.2.6, close this issue.