PlayFab / consuldotnet

.NET API for Consul (http://www.consul.io/)
Apache License 2.0
692 stars 193 forks source link

deregister returns OK but service not deregistred #103

Open HansHammel opened 6 years ago

HansHammel commented 6 years ago

it seems that consul wants a node specified

this works:

curl -XPUT http://localhost:8500/v1/catalog/deregister -d '{ "Node":"dc1", "Name": "IS4ProtectedAPI v1.0.0.0"}' this doesn't:

curl -XPUT http://localhost:8500/v1/catalog/deregister -d '{ "Name": "IS4ProtectedAPI v1.0.0.0"}'

so your deregiester method Needs aditional Parameters

One more bug:: IS4ProtectedAPI v1.0.0.0 is the NAME (not the ID) of the Service

I notice you are not the maintainer of the nuget package I used, are you?

wayne-o commented 6 years ago

I am also seeing this

Although I am confused as the docs do not mention Node https://www.consul.io/api/agent/service.html#deregister-service

wayne-o commented 6 years ago

My mistake - it doesn't dereg during a debug session but runing in terminal works