search

PlayFab / gsdk

Game Server SDK for PlayFab Multiplayer Servers
https://docs.microsoft.com/en-us/gaming/playfab/features/multiplayer/servers/
Apache License 2.0
146 stars 115 forks source link

Renaming Playfab to PlayFab in UE plugin for consistency and proper working. #137

Closed igor-sadchenko closed 1 year ago

igor-sadchenko commented 2 years ago

Fix #136

nassosterz-ms commented 2 years ago

I am wondering why this hasnt been an issue all this time. Are you reproducing it only on MacOS?

Have you run alredy GenerateVisualStudioProjectFiles? If so, does this fail - succeed?

igor-sadchenko commented 1 year ago

It's appears only on MacOS with UE 5.0 Here is a log sample

LogCsvProfiler: Display: Metadata set : platform="Mac"
LogCsvProfiler: Display: Metadata set : config="Development"
LogCsvProfiler: Display: Metadata set : buildversion="++UE5+Release-5.0-CL-20979098"
LogCsvProfiler: Display: Metadata set : engineversion="5.0.3-20979098+++UE5+Release-5.0"
LogCsvProfiler: Display: Metadata set : commandline="" /Users/ts/prj/Prj.uproject""
LogCsvProfiler: Display: Metadata set : os="12.6.1 21G217"
LogCsvProfiler: Display: Metadata set : cpu="GenuineIntel|Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz"
LogCsvProfiler: Display: Metadata set : pgoenabled="0"
LogCsvProfiler: Display: Metadata set : loginid="bf494c5b484573aa645ef7b887f2c306"
LogCsvProfiler: Display: Metadata set : llm="0"
LogPlatformFile: Not using cached read wrapper
LogStats: Stats thread started at 1.015197
LogICUInternationalization: ICU TimeZone Detection - Raw Offset: +2:00, Platform Override: ''
LogInit: Session CrashGUID >====================================================
         Session CrashGUID >   UECC-Mac-E53CA5C89041375E8A94E88A77EE1AAB
         Session CrashGUID >====================================================
...
Message dialog closed, result: Ok, title: Message, text: Plugin 'PlayfabGSDK' failed to load because module 'PlayFabGSDK' could not be found.  Please ensure the plugin is properly installed, otherwise consider disabling the plugin for this project.
LogCore: Engine exit requested (reason: EngineExit() was called)
dylanh724 commented 1 year ago

I am wondering why this hasnt been an issue all this time. Are you reproducing it only on MacOS?

Windows is generally not prone to path case sensitivity - so if this can happen on Linux, it's probably there too.

Leonardo-Rocha commented 1 year ago

I just reproduced here while building for Linux as well, I'll try the fix

nassosterz-ms commented 1 year ago

@igor-sadchenko can you resolve the conflicts so that I merge this?

nassosterz-ms commented 1 year ago

Opened a separate PR with the merge conflicts being resolved.

nassosterz-ms commented 1 year ago

Closing as: https://github.com/PlayFab/gsdk/pull/137/files is merged.

Thank you so much for contributing in this work!