search

PlayFab / gsdk

Game Server SDK for PlayFab Multiplayer Servers
https://docs.microsoft.com/en-us/gaming/playfab/features/multiplayer/servers/
Apache License 2.0
146 stars 115 forks source link

Unreachable Code during compilation for UE 5.4.1 #171

Closed VoidConcepts closed 5 months ago

VoidConcepts commented 5 months ago

Describe the bug A new project built from source for Unreal Engine 5.4.1 will not build when trying to integrate the PlayFabGSDK plugin. After adding it to the project:

"UnrealPlugin/Source/PlayFabGSDK/Private/PlayFabGSDK.cpp" On line 136 and 146 Visual Studio 2022 return errors, "Unreachable Code."

To Reproduce Steps to reproduce the behavior: Follow the integration steps for an unreal project using UE 5.4.1 (Source).

Expected behavior I expected the project to build as normal. Similarly to my project using UE 5.3.2

Screenshots This is the Original Code. Original

This is what I edited it too. Edited

Desktop (please complete the following information):

Additional context Added an, "#else", and moved the, "#endif". which at least let me build my project for the Editor, Client, & Server, targets. Haven't tested any further than this.

tculotta commented 5 months ago

Thanks you for this catch! We haven't officially tested 5.4 support yet, so please do submit issues for anything else you find in the meantime.