search

PlayFab / thundernetes

Thundernetes makes it easy to run your game servers on Kubernetes
https://playfab.github.io/thundernetes
Apache License 2.0
307 stars 46 forks source link

Changed Kustomize version to latest to get rid of Test errors on Mac … #392

Closed stefanvo78 closed 1 year ago

stefanvo78 commented 1 year ago

Fixed an error for Mac OS with M1. Therefor I changed the version of Kustomize to the newest (4.5.7)

dgkanatsios commented 1 year ago

so the unit tests break, because make create-install-files makes the git state dirty. This is because newer versions of kustomize rely on a version of go-yaml that incurred a breaking change.

https://github.com/kubernetes-sigs/kustomize/issues/947

There has been a request to fork the project but the fix is still not in kustomize: https://github.com/kubernetes-sigs/yaml/issues/72

The thing is that newer versions of kustomize are MUCH faster. If we use it, this will speed up local development plus end to end tests. To this end, I vote to merge this PR after we validate that the new YAML files work.

@stefanvo78, the only change needed in this PR is to run make create-install-files at the root folder. Thank you!

dgkanatsios commented 1 year ago

Closing as change was included in #419