search

PlayFab / thundernetes

Thundernetes makes it easy to run your game servers on Kubernetes
https://playfab.github.io/thundernetes
Apache License 2.0
313 stars 47 forks source link

[Integration with AzureMonitor]: Adding changes to send metrics for Standingby servers to AppInsights. #405

Closed rangira closed 1 year ago

rangira commented 2 years ago

The PR addresses the issue https://github.com/PlayFab/thundernetes/issues/383

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.

dgkanatsios commented 2 years ago

hey @rangira, thanks for the PR! Ideally, we would not want to have product specific code inside Thundernetes. Any chance we can have Azure Monitor grab the already existing Prometheus metrics? If this is not possible, we can always have an external component on the ThundernetesContrib repository: https://github.com/PlayFab/thundernetescontrib

Thanks again for the contribution and apologies for the inconvenience!

dgkanatsios commented 2 years ago

Would this work, for example? https://learn.microsoft.com/en-us/azure/azure-monitor/containers/container-insights-prometheus-integration

rangira commented 2 years ago

@dgkanatsios Thank you for sharing that. Could you please help me understand what are referring to when you say "product specific code". Are you referring to azure sdk for appinsights? Should it not be imported? I can take a look at link

dgkanatsios commented 2 years ago

Yeah, the "AppInsights" code, exactly. At this point, we want to have these available as "extensions", hence the existence of the "ThundernetesContrib" repository as we want the Thundernetes core code base to be as lean as possible. Apologies again for the inconvenience and thanks for understanding, lets us know if you have any more questions!

dgkanatsios commented 2 years ago

ping @rangira, any help needed? Appreciate all the hard work!

dgkanatsios commented 1 year ago

Closing because of inactivity, feel free to reopen if needed. Thanks!