PlayFab / thundernetes

Thundernetes makes it easy to run your game servers on Kubernetes
https://playfab.github.io/thundernetes
Apache License 2.0
307 stars 46 forks source link

Add Allocation Service Metrics #414

Closed abbasahmed closed 1 year ago

abbasahmed commented 1 year ago

Problem: We currently do not have a lot of metrics around Allocations API service in Thundernetes. Reference: Issue #384

Solution:

This PR adds in 6 metrics:

These new metrics can help us monitor the allocation service in ways such as monitoring the performance of allocation service in terms of speed and reliability. The metrics allow us to quickly monitor the errors of allocation service helping us to make quicker inferences/decisions.

Along with the metrics, we have also added a couple of panels in the Grafana dashboard to visualize these events.

image image
ghost commented 1 year ago

CLA assistant check
All CLA requirements met.

dgkanatsios commented 1 year ago

Great work! Can you add a small description on the PR? Thanks!

abbasahmed commented 1 year ago

Hi @dgkanatsios, I've added a description of the PR. Also a heads up, we are currently still adding some code changes so currently the PR is in draft status.

dgkanatsios commented 1 year ago

hey @abbasahmed, let me know how I can help to land this PR! Appreciate all the hard work, thanks!

dgkanatsios commented 1 year ago

@abbasahmed @ghov kind ping, we want to release 0.6 next week and it would be great to include your changes!

abbasahmed commented 1 year ago

@dgkanatsios will resolve the conflicts and publish the PR today. Sorry for the hold up on this PR!

dgkanatsios commented 1 year ago

thanks @abbasahmed, let me know if you need any help!