PlayPickUp / pickup-ui

A collection of React Components that make up the PickUp world. 🌎⚡
https://ui.playpickup.com
3 stars 1 forks source link

Fix(cssReset): add background-image and background to button reset #282

Closed wliederer closed 2 years ago

wliederer commented 2 years ago

In reviewing css reset for button it seems a number of things could be the issue and is difficult to test locally.

Right now the button styles colors are set under css attribute background ex
background: theme.gradients.main,

the css reset for button was only reseting backgroundColor:transparent

i added background:inherit -- which means we will set that value which we already are

then in seeing issues with publishers below under background-image, background, and box-shadow i defined background-image and box-shadow as none in an attempt to not allow anything in. If this does not seem to work we could label them as inherit and set them in our button styles to prevent word press styles coming in.

let me know what you guys think

LWOS is seeing an issue with box-shadow and background-image coming in to override our background styles image

FullPressCoverage also shows minor issues with button and background-image image