PlayPickUp / pickup-ui

A collection of React Components that make up the PickUp world. 🌎⚡
https://ui.playpickup.com
3 stars 1 forks source link

feat(pickerPercentages): Add unique className to pickers to solve CSS problems #291

Closed KrystineJannenga closed 2 years ago

KrystineJannenga commented 2 years ago

feat(pickerPercentages): Add unique className to pickers to solve CSS problems (close prop-picker #124)

KrystineJannenga commented 2 years ago

this is funky to test - you have to yarn link to prop picker to see updates when multiple pickers on one page. What it does is creates a unique ID attached to the prefix "PU--" to make every classname unique for prop picks not to have the same CSS classNames and being overwritten. When you run storybook you can see this new id added (picker percentage loader classname in screenshot). Updates in tests were configured to the unique id for each picker. Real changes happened in ThemeProvider.

If you have any questions or need help please ask me lol this is a weird one. :)

Screen Shot 2022-02-01 at 2 37 59 PM