PlayPickUp / pickup-ui

A collection of React Components that make up the PickUp world. 🌎⚡
https://ui.playpickup.com
3 stars 1 forks source link

fix(nestedInput): Revert resets, add manual style overrides to phone button, ENG-67 #313

Closed dLars99 closed 2 years ago

dLars99 commented 2 years ago

The previous fix, when paired with withReset={false}, is too specific. The reset carries through to child elements, and effectively wipes out the button.

Reverted the reset fix and added stylings directly to the button element that is overridden by Nascar's styles, with the intention of revisiting resets to find a better long-term solution.

linear[bot] commented 2 years ago
ENG-67 Submit button shifts inside Nested Input

On mobile devices, after submitting the user's phone number, the Submit button shifts inside the verification input: ![Image from iOS.png](https://uploads.linear.app/da4ce42f-b012-40fa-b6e3-38645e9f0ed2/d2cad4f3-bf9d-440b-aa77-e860f592389c/d985b0c9-ed7d-4232-87e6-dd8007147d4a) So far, this has only been observed on Nascar. [PlayPickup.com](http://PlayPickup.com) does not show this same behavior. [https://www.nascar.com/news-media/2022/02/24/kyle-busch-relishes-nascar-cup-series-return-to-auto-club-speedway/](https://www.nascar.com/news-media/2022/02/24/kyle-busch-relishes-nascar-cup-series-return-to-auto-club-speedway/) [View original issue in GitHub](https://github.com/PlayPickUp/prop-picker/issues/188) --- **dLars99** 2022-02-25 UPDATE: Just saw this on the desktop site as well **dLars99** 2022-03-02 Reopening. UI adjustments have unintended side-effects when added to the Picker