search

PlayPro / CoreProtect

CoreProtect is a blazing fast data logging and anti-griefing tool for Minecraft servers.
Artistic License 2.0
673 stars 343 forks source link

[Suggestion]Make CoreProtect compatible with Fabric #37

Open Peter-JY opened 3 years ago

Peter-JY commented 3 years ago

This Mod is write for Bukkit and Spigot, but some servers runs with Fabric. Is it possible to make it compatible with Fabric? (Now if I put this in the mods folder, it will say [12:07:44] [ForkJoinPool-1-worker-5/WARN]: Non-Fabric mod JAR at "D:\Peter\MinecraftServer-Fabric-1.15.2\mods\CoreProtect-19.5.jar", ignoring)

emielderckx commented 3 years ago

This is a bukkit plugin not a fabric mod so no it will not work and you can't change that quickly...

Just search on modrinth or curseforge for ledger thats somewhat the same as coreprotect

Peter-JY commented 3 years ago

The question is, I’ve searched, and found that there isn’t any Mod that makes for Fabric, and Fabric and Spigot can’t run together (Spigot don’t load Fabric as a plugin or Fabric can’t load Spigot as Minecraft Server)☹️, So I ask for help in this issues......

Peter-JY commented 3 years ago

And, many this kind of mods are made for Spigot......

emielderckx commented 3 years ago

It just said that you need to search for Ledger....

https://modrinth.com/mod/ledger

soshimee commented 3 years ago

https://www.curseforge.com/minecraft/mc-mods/cardboard This claims to be able to run Spigot plugins on Fabric, but to my testing, only ~95% of plugins would work. Also, they broke after reverting to Spigot (I think it modifies the original plugin jar).

vacla commented 3 years ago

Please dont use cardboard, this has all the things why you shouldnt use it: https://gist.github.com/Patbox/e44844294c358b614d347d369b0fc3bf Ledger is good in progress for a CoreProtect like from what i have seen/heard

Sebas-Re commented 2 years ago

I can only dream for the day CoreProtect gets ported to fabric... I know ledger exists, but CoreProtect is simply far superior than that crap :/

Sebas-Re commented 2 years ago

RIP

emielderckx commented 2 years ago

RIP

Stop crying, Ledger is an almost perfect CoreProtect alternative if you still miss anything give them feedback or PR changes yourself.

And if you really want CoreProtect on Fabric port it yourself or pay someone to do it. Then you will learn how much time or money this takes.

Respect open source developers more...

Sebas-Re commented 2 years ago

Stop crying, Ledger is an almost perfect CoreProtect alternative if you still miss anything give them feedback or PR changes yourself.

If you compare it with CoreProtect and test it out on a server, you will quickly realise it is far from perfect, with only 6 actions being logged, among other stuff. I did gave feedback on their GitHub with the things I think should be added to enhance the mod, and got no answer.

And if you really want CoreProtect on Fabric port it yourself or pay someone to do it. Then you will learn how much time or money this takes.

Respect open source developers more...

And about this, I'm not forcing anyone lmfao, I was just asking if it was possible to get it ported (you can check the issue Intelli mentioned back on June). Any reply (as long as it's being delivered in a respectful way...) would have been fine for me.

funnyyt111 commented 1 year ago

It just said that you need to search for Ledger....

https://modrinth.com/mod/ledger

But Ledger is not working on my server...It says 'No results for this search'

emielderckx commented 1 year ago

It just said that you need to search for Ledger.... https://modrinth.com/mod/ledger

But Ledger is not working on my server...It says 'No results for this search'

That has nothing to do with Core Protect. Go ask Fabric Server Tools (Ledger) for help.

Nano112 commented 1 year ago

As a bump to the issue, ledger is far from being anywhere close to the quality of CoreProtect, it's actually unusable in production as is between the slow lookups, frequent crashes / log drops and very little amount of things actually being logged. Up until now there has been no actual discussion of a potential fork / port of CoreProtect, only references to ledger. Seeing that fabric will only rise in popularity in the future, I think an actual discussion of feasability / plans is not a bad thing to put on the table. Not really asking for the port itself, but at least an insight of it's feasability and / or timeline if it is something that is considered because in my mind CoreProtect is the last eleemnt required to allow proper production grade fabric servers

Thorinwasher commented 1 year ago

I don't think it's impossible, but it would require quite some work to make things going. Here's what will be different for working with fabric (I'm only a bukkit developer, so mostly guessing)

I would almost say that it would be easier to optimize/fix Ledger instead, as it already uses the fabric api and probably has the extra needed functionality needed for fabric.

But sure, it is feasible to make a fabric port of Coreprotect given enough work and time, but is it worth it?

Nano112 commented 1 year ago

Well that's why I feel like a conversation should at least be open, because it definitely is possible, many other plugins support multi-server targets through the use of a common backend and a interface system to be able to build multiple targeted plugins, using the same core codebase. It has been done, but it doesn't mean the current code architecture of CoreProtect would allow it without a massive rewrite, but it could also be architectured in a way that it wouldn't be a massive task, hence why it has to be looked at and discussed.

Also the core game is still the same, I feel like it wouldn't be CoreProtect's responsability to handle third party mods, more to offer an API for those third parties to use.

I am 100% convinced it is worth it, since it's release fabric has been consistently gaining users. I metrics through the growth of spigot plugin vs fabric mod count on modrinth / curseforge. Spigot up until now has had the andvantage through it's maturity but the fact that fabric uses yarn which is based on the official minecraft obfuscation maps, yielding a much closer api to the real game instead of the reverse engineered mappings of bukkit or forge, is giving it an andvantage on the long term.

Thorinwasher commented 1 year ago

Even to allow a new api to be used requires some work; Coreprotect still needs to store all of the information properly in a database. My guess is that Intelli will not make Coreprotect fabric compatible, because of the time it takes. That means someone else has to do it.