search

PlayPro / CoreProtect

CoreProtect is a blazing fast data logging and anti-griefing tool for Minecraft servers.
Artistic License 2.0
644 stars 323 forks source link

fix: folia check to be compatible with shreddedpaper #551

Closed ProdPreva1l closed 3 months ago

ProdPreva1l commented 4 months ago

ShreddedPaper is fully compatible with all folia plugins if don't check if its folia, BUT we have an empty class for RegionizedServer as MOST plugins will check for this, please be like everyone else!

Intelli commented 4 months ago

CoreProtect’s Folia check can be found here: https://github.com/PlayPro/CoreProtect/blob/ca59ff25dfa5abf9b4f0537255a89ba8a3511db5/src/main/java/net/coreprotect/utility/Util.java#L1315

ProdPreva1l commented 3 months ago

CoreProtect’s Folia check can be found here:

https://github.com/PlayPro/CoreProtect/blob/ca59ff25dfa5abf9b4f0537255a89ba8a3511db5/src/main/java/net/coreprotect/utility/Util.java#L1315 lol ik thats why i modified it to use a more conventional class so that core protect can be compatible with more servers without you needing to do anything, this is a PR not an issue, maybe check the edited files next time ;)

Intelli commented 3 months ago

Oh yeesh, going through things too quickly and didn’t even notice this was a PR.

That change is fine.