PlayPro / CoreProtect

CoreProtect is a blazing fast data logging and anti-griefing tool for Minecraft servers.
Artistic License 2.0
673 stars 343 forks source link

missing data in wolf and cat death logs #648

Open AbigailBrady opened 2 months ago

AbigailBrady commented 2 months ago

Testing on our 1.21.1 server that has CoreProtect 23.1 installed and discovered that wolf variants (new to MC 1.20.5) are not serialised.

in EntityDeathListener.java we have

            info.add(BukkitAdapter.ADAPTER.getRegistryKey(cat.getCatType()));

for cats but nothing equivalent for wolves. Also, while looking at this, I realised that it does have this line for dogs:

            info.add(wolf.isSitting());

which is missing in cats, as cats can sit as well. I then confirmed this by killing a sat cat and restoring - it restored unsat.

It might be worth doing a full scan to see if there is anything else that is missing.