PlayWithMagic / PlayWithMagic.org

PlayWithMagic.org is a web application that catalogs magic tricks and helps magicians build shows.
http://playwithmagic.github.io/PlayWithMagic.org/
Apache License 2.0
2 stars 1 forks source link

Cleanup dead Branches #148

Open pkarjala opened 9 years ago

pkarjala commented 9 years ago

We have a lot of floating branches that will never be touched again. Suggest cleaning up all branches from any Milestone prior to the current one, not including the Milestone branch itself.

I.E., keep Milestone-1, but delete any branches merged into it prior to then.

marknelsonengineer commented 9 years ago

Question: Can we ask Dr. Johnson for his advice first? I’d be happy to writeup a post.

Mark

On Apr 18, 2015, at 9:31 AM, Patrick A. Karjala notifications@github.com wrote:

We have a lot of floating branches that will never be touched again. Suggest cleaning up all branches from any Milestone prior to the current one, not including the Milestone branch itself.

I.E., keep Milestone-1, but delete any branches merged into it prior to then.

— Reply to this email directly or view it on GitHub https://github.com/PlayWithMagic/PlayWithMagic.org/issues/148.

pkarjala commented 9 years ago

Certainly!

marknelsonengineer commented 9 years ago

I did a short study to understand the implications of deleting branches. The commits remain, but are unlabeled. If you look at Graphs->Network, you'll see all of the old branches, but they just don't have labels. I think this is ideal because we don't loose 'stats' with respect to Dr. Johnson's auditing the code, but new developers don't have to wade through a bunch of old branches.

I'll start weeding out the old development branches, but I'll retain any milestones like the Mockup.

marknelsonengineer commented 9 years ago

Done for Milestone-2

pkarjala commented 9 years ago

Awesome, I think this is a good best practice, to clean up the previous Branches that aren't a Milestone or related to other in-development items.

pkarjala commented 9 years ago

Cleanup of old pre-Milestone 2 Branches has been completed.