search

PlayWithMagic / PlayWithMagic.org

PlayWithMagic.org is a web application that catalogs magic tricks and helps magicians build shows.
http://playwithmagic.github.io/PlayWithMagic.org/
Apache License 2.0
2 stars 1 forks source link

Set up default images for Profile, Routines, and Materials #189

Closed pkarjala closed 9 years ago

pkarjala commented 9 years ago

If a user does not upload an image, we should have one that is filler that shows up in the space where the image should be.

pkarjala commented 9 years ago

The best method for doing this would be to simply utilize FontAwesome icons to fill in for blank information.

Suggested icons:

Magician: http://fortawesome.github.io/Font-Awesome/icon/user/ Routine: http://fortawesome.github.io/Font-Awesome/icon/magic/ Material: http://fortawesome.github.io/Font-Awesome/icon/paperclip/ or http://fortawesome.github.io/Font-Awesome/icon/fire/

Alternatively we can use the generic http://fortawesome.github.io/Font-Awesome/icon/picture-o/ for all of them.

davidkneely commented 9 years ago

Have implemented placeholders with font-awesome. Icon does not scale with responsive layout. Should we just create images in photoshop with the font awesome icon? Then the image will be responsive and scale with the page. #189

pkarjala commented 9 years ago

Let's see how it looks with just the FA Icons and responsiveness.

davidkneely commented 9 years ago

Still having issues compiling LESS. Enabled filewatcher but getting error: 3:24:27 PM An exception occurred while executing watcher 'LESS'. Watcher has been disabled. Fix it.: Invalid executable

pkarjala commented 9 years ago

That's an issue with it not being able to find lessc on your system.

pkarjala commented 9 years ago

Taking a closer look, it looks like the <i> tags weren't properly being closed with </i>, so this is also now fixed.

Have set font-size: 400px; for placeholder image.