Closed pkarjala closed 9 years ago
Some thought needs to be put into how to close an account. What happens to their routines and people’s contributions to them? I’m thinking that during R&D we can delete magicians, but long term, we should set the status to inactive and disable the password. It's important to retain the data/links.
This behavior needs to include unit tests.
Here are the modules suggested by Dr. Johnson:
Deadbolt 2 Play Authenticate uses parts of Deadbolt 2 Secure Social
I downloaded Play Authenticate and poked at it a bit tonight. It's a mess. The code completely lacks JavaDocs anywhere, and the existing online documentation is out of date.
That said, I was able to run the test application without issues, and it does function correctly. It also does look usable in spite of the code standards issues.
I've made a post to the class discussion group to check on whether we're expected to hold external libraries to the same standards we hold our own code.
I'm also going to take a look at the other two options and see how they fare.
So after spending all afternoon fighting with Secure Social, SBT import statements, conflicting documentation, and the fact that it, ultimately, is really written for Scala-based Play projects, I've pivoted back to Play-Authenticate. Will have an update later tonight.
I have a working base Digits homepage with all of the setup Play-Authenticate functionality. Next I need to clean up some of the navigation issues with the sample Digits application, as right now that login / signup buttons display, but throw errors when you attempt to navigate between them.
Way to go.
I’m updating platform installation instructions (to integrate the test stuff).
Mark
On Apr 25, 2015, at 9:15 PM, Patrick A. Karjala notifications@github.com wrote:
I have a working base Digits homepage with all of the setup Play-Authenticate functionality. Next I need to clean up some of the navigation issues with the sample Digits application, as right now that login / signup buttons display, but throw errors when you attempt to navigate between them.
— Reply to this email directly or view it on GitHub https://github.com/PlayWithMagic/PlayWithMagic.org/issues/45#issuecomment-96336232.
I should note that a user still cannot login, or sign up. I just finally got Play-Authenticate to compile inside of Digits without throwing any errors. However, now that this is fixed, it should be doable from here.
I had to move in all of the sample .java, .scala.html files, and so forth from play-authenticate in order to get it up and running. This means all of the uncommented, incorrectly formatted code is now in Digits.
Interesting note: you cannot use "User" for the User class. "User" is a restricted name as far as PSQL is concerned. Working on refactoring.
OK, the proof of concept is working, and can be tried from the "example-login" branch of my Digits application at https://github.com/pkarjala/digits/tree/example-login
Still to implement
OK, this has been completed and is now functional on Digits at https://github.com/pkarjala/digits/tree/example-login. I will start work from here in Milestone 3.
Marking this issue as complete, will create new issue for migration of workflow into PlayWithMagic.
Should support a username, password, and "logged-in" state that can be used by the site to determine what type of information to display to the user.