PlayersCommittee / gemp-swccg-public

Online Play system for SWCCG
https://gemp.starwarsccg.org/
MIT License
27 stars 29 forks source link

All reverts disable right-click zooming #741

Closed Gergall closed 5 months ago

Gergall commented 5 months ago

Describe the bug

Right-clicking a card to zoom stops working as soon as a revert occurs

To Reproduce

Steps to reproduce the behavior:

  1. Perform any revert
  2. Right-click on a card. It won't zoom.

Game Replay ID:

No need for a replay. Just do a turn 1 revert in any game.

Expected behavior

Right-clicking a card normally zooms, same as shift+click.

Additional context

Ketura recently added the right-click zooming, around December 2023. Ketura's experience is primarily in LOTR GEMP which does not have reverts, so this issue never came up in LOTR. It's possible that there is some bit of code somewhere that helps shift-click continue to work after a revert, in which case right-click needs to receive that same help.