PlayersCommittee / gemp-swccg-public

Online Play system for SWCCG
https://gemp.starwarsccg.org/
MIT License
27 stars 29 forks source link

LS Kashyyyk system not restricting destiny draw against Xizor piloting. #771

Closed SuburbanJ closed 1 month ago

SuburbanJ commented 1 month ago

Describe the bug

Battle occurred at LS Kashyyyk. DS had Jabba's space cruiser with Xizor piloting (ability 5 total), Proxima, Ponda Baba, and an outer rim scout aboard, with IG-88 in IG-2000 there as well. Battle occurred, DS should have 0 destinies, but drew one anyways.

To Reproduce

Steps to reproduce the behavior:

  1. Xizor piloting a ship in battle at Kashyyyk with <6 ability total.
  2. See error

Game Replay ID:

https://gemp.starwarsccg.org/gemp-swccg/game.html?replayId=SuburbanJ$hqk9qeqlhafcy3yl Turn 6 is when the event occurred.

Expected behavior

DS should not be allowed to draw any battle destiny due to not satisfying Kashyyyk's ability requirement.

Client Platform

Desktop (please complete the following information):

Additional context

It's possible that it's caused by either IG-88 in IG-2000 or Lady Proxima, but I think the most likely cause is Xizor's text triggering in a space battle when it should only work at sites.

EchoBaseTrooper commented 1 month ago

This is not a bug. Outer Rim Scout was piloting, not Prince Xizor. Outer Rim Scout draws battle destiny if unable to otherwise when piloting an [Independent] starship.

Relevant part of game log: ElDuderino moves •Prince Xizor from pilot capacity slot to passenger capacity slot of •Jabba's Space Cruiser (V) ElDuderino deploys Outer Rim Scout from •Den Of Thieves on •Jabba's Space Cruiser (V) as pilot

SuburbanJ commented 1 month ago

We both totally didn’t realize he had done that! Thank you for looking into it!

On Wed, Jun 26, 2024 at 11:43 PM Adam Fletcher @.***> wrote:

This is not a bug. Outer Rim Scout was piloting, not Prince Xizor. Outer Rim Scout draws battle destiny if unable to otherwise when piloting an [Independent] starship.

Relevant part of game log: ElDuderino moves •Prince Xizor from pilot capacity slot to passenger capacity slot of •Jabba's Space Cruiser (V) ElDuderino deploys Outer Rim Scout from •Den Of Thieves on •Jabba's Space Cruiser (V) as pilot

— Reply to this email directly, view it on GitHub https://github.com/PlayersCommittee/gemp-swccg-public/issues/771#issuecomment-2193384020, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWEE4BGLAKSYE45XOCPYHDZJOC5LAVCNFSM6AAAAABJ7AM3J6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJTGM4DIMBSGA . You are receiving this because you authored the thread.Message ID: @.***>