PlayersCommittee / gemp-swccg-public

Online Play system for SWCCG
https://gemp.starwarsccg.org/
MIT License
27 stars 29 forks source link

Tonnika Sisters (V) applying to more than just owner and battle destinies #814

Open Gergall opened 3 hours ago

Gergall commented 3 hours ago

Describe the bug

Tonnika Sisters (V) says "Twice during battle, may double your just drawn battle destiny of 2." She seems to be able to double other types of destinies, like weapon destinies. That's a bug. She also seems to be able to double the opponent's destinies. That's also a bug.

Game Replay ID:

https://gemp.starwarsccg.org/gemp-swccg/game.html?replayId=sac89837$kb8lx6m4j7o4hr7t In this game, LS draws Melas for destiny and DS is able to double it.

Expected behavior

Tonnika Sisters (V) should only be able to double a destiny if it's the owner's destiny AND it also has to be a battle destiny.

Gergall commented 3 hours ago

Tonnika Sisters (V) is DS card 222_015

It looks like conditions to check for "owner's destiny" and "battle destiny" might need to be added either around line 70 (where the comment says "Check conditions") or around line 74 (where the comment says "Check more conditions")