search

PlayersCouncil / LotR-TCG_card_generator

nanDECK script for generating Lord of the Rings TCG cards from CSV.
6 stars 0 forks source link

full_portrait not working in some combinations #30

Closed morvael closed 4 years ago

morvael commented 4 years ago

Currently full_portrait works correctly only for cards with full_art also set. But for full_art cards full_portrait shouldn't even be required. And for some cards I want only full_portrait.

Please make sure the following combinations work: full_art (should be equal to full_art full_portrait) full_portrait full_portrait no_rotate

morvael commented 4 years ago

1st I need for character/modifier cards with their own "template" including picture (rings, countdown, some masterworks). 2nd I need for other cards, except sites (to use unscaled card as picture source, but apply template on top). 3rd I need for sites (to use unscaled, horizontal card as picture source, but apply template on top, and do not rotate final image to vertical).

ketura commented 4 years ago

The issue here is one of miscommunication over the intent and usage of full_art and full_portrait, I believe. I'm going to add more intuitive names for the tags as aliases, and update the documentation accordingly.

ketura commented 4 years ago

I have added aliases for these two.

full_art is now no_template full_portrait is now portrait_backdrop

The old ones can be used, but documentation is updated to refer to the new ones, instead.