PlayersCouncil / LotR-TCG_card_generator

nanDECK script for generating Lord of the Rings TCG cards from CSV.
6 stars 0 forks source link

Culture icon rendered on full_art cards #45

Open morvael opened 3 years ago

morvael commented 3 years ago

Buggy condition causes culture icon to be rendered on cards with full_art tag.

morvael commented 3 years ago

I think there are two bugs in the condition:

IF= ("full_art" @ {tags?§}) _AND_ ("onering" # {template?§}) _AND_ ("disable_culture" # {tags?§}) _AND_ ( ([card_type] <> "modifier") _OR_ ("artifact_overlay" # {tags?§}))

should be

IF= ("full_art" # {tags?§}) _AND_ ("onering" # {template?§}) _AND_ ("site" # {template?§}) _AND_ ("disable_culture" # {tags?§}) _AND_ ( ([card_type] <> "modifier") _AND_ ("artifact_overlay" # {tags?§}))
morvael commented 3 years ago

Also added condition to ommit sites (generated warning in nandeck looking for empty culture overlay.

morvael commented 3 years ago

Perhaps this is the final correct version:

IF= ("full_art" # {tags?§}) _AND_ ("onering" # {template?§}) _AND_ ("site" # {template?§}) _AND_ ("disable_culture" # {tags?§}) _AND_ ([card_type] <> "Artifact") _AND_ ("artifact_overlay" # {tags?§})