PlayingNumbers / ds_salary_proj

Repo for the data science salary prediction of the Data Science Project From Scratch video on my youtube
295 stars 298 forks source link

Regarding Average Salary #5

Open jaypandya12 opened 4 years ago

jaypandya12 commented 4 years ago

Hello Ken,

I followed your youtube video on this project and I have doubt regarding the salary column. When we created the avg_salary column in the data we took the average of min and max salary for all records including the records where the salary estimate is given in per hour. But when we convert hourly to annual in the EDA notebook we don't update the avg_salary column. Would it make any difference or am I mistaken? Please let me know. @PlayingNumbers

Shaon2221 commented 4 years ago

Hello @jaypandya12 , Please check out, exploratory data analysis video of this project carefully. Mr. Ken Jee solved this issue there.

dirty-demon commented 3 years ago

@PlayingNumbers how u converted per hour data in annual by just multiplying by 2 in upper or lower salaries...!!!!

dirty-demon commented 3 years ago

please do help and reply......!! we're working on same kinda project ...and still stucked...

vzaidman commented 2 years ago

hourly work hours a day days a month months a year = annual hourly 8 22 12 = hourly 2112 for example: 40 per hour 2112 = 84,480 and in thousands -> 40 per hour * 2.1 = 84 so X2 is reasonable

vzaidman commented 2 years ago

when we convert hourly to annual in the EDA notebook we don't update the avg_salary column.

I believe you are right. he had to multiply avg_salary by 2 too in places where it was given as a hourly salary.

Urias-T commented 2 years ago

hourly work hours a day days a month months a year = annual hourly 8 22 12 = hourly 2112 for example: 40 per hour 2112 = 84,480 and in thousands -> 40 per hour * 2.1 = 84 so X2 is reasonable

This is a perfect explanation... I couldn't understand the thought process while watching the video but I understand it now. Thank you.