search

PlaytikaOSS / feign-reactive

Reactive Feign client inspired by https://github.com/OpenFeign project
Apache License 2.0
618 stars 125 forks source link

FilteredReactiveRetryPolicy with ExceptionPopagationPolicy #659

Closed AmanKamani closed 2 months ago

AmanKamani commented 10 months ago

FilteredReactiveRetryPolicy doesn't override the exceptionPropagationPolicy from ReactiveRetryPolicy. So, either it should override that or use the exceptionPropagationPolicy from the RetryPolicy which it takes as an argument of constructor.

Now, Let's say we are passing BasicReactiveRetryPolicy (with ExceptionPropagationPolicy as UNWRAP) while creating instance for FilteredReactiveRetryPolicy. When Retries are exhuasted, that time exceptionPropagationPolicy flag will be NONE. So, it won't unwrap the OutOfRetryException. So, we need to override the exceptionPropagationPolicy in FilteredReactiveRetryPolicy.

AmanKamani commented 10 months ago

@kptfh I have raised PR for this: https://github.com/PlaytikaOSS/feign-reactive/pull/658

kptfh commented 2 months ago

fixed in https://github.com/PlaytikaOSS/feign-reactive/pull/679