search

PlaytikaOSS / feign-reactive

Reactive Feign client inspired by https://github.com/OpenFeign project
Apache License 2.0
600 stars 119 forks source link

Clients Target.name not correspond to ReactiveFeignClient.name #669

Open Donquih0te opened 4 months ago

Donquih0te commented 4 months ago

If I specify name and url attributes in @ReactiveFeignClient annotation

@ReactiveFeignClient(
    name = "clientName",
    url = "http://google.com",
    path = "/path",
    configuration = Configuration.class
)

Then the client's feign.Target.name (feign.Target.HardCodedTarget) would not be equal to ReactiveFeignClient.name: HardCodedTarget(type=Client, url=http://google.com, name=http://google.com)

However, if I specify only name without url attribute in @ReactiveFeignClient annotation

@ReactiveFeignClient(
    name = "clientName",
    path = "/path",
    configuration = Configuration.class
)

then the client's feign.Target would look like: HardCodedTarget(type=Client, url=http://clientName, name=clientName)

Why, if I specify both name and url attributes, Target.name is not equal to ReactiveFeignClient.name?