Plazmaz / Duckuino

A basic Duckyscript to Arduino converter
MIT License
61 stars 23 forks source link

Please redirect to my git instead of Thecakegit's git #13

Closed d4n5h closed 8 years ago

d4n5h commented 8 years ago

My compiler is better than Thecakegit's compiler: https://github.com/DanielShlomo/Duckuino

As your git is getting more attention it will be better if you'll switch to my compiler/converter.

Changes: Added support for: REM,ESCAPE and REPLAY/REPEAT. Added support for mouse movements and clicks ("MOUSEMOVE xPos,yPos,wheelPos" | "MOUSECLICK left/right/middle"). Fixed empty lines bug. Rearranged the code and files. Added simple Bootstrap CDN UI. Switched to associative arrays/objects to reduce the use of For loops. Added functionality for key combos. Removed console.error for comands (i'll try to reimplement it back again).

lowlevl commented 8 years ago

I added support of REM and ESCAPE and i'll add REPEAT soon, your compiler is totally buggy:

Keyboard.press('KEY_LEFT_CTRL');Keyboard.press('KEY_LEFT_ALT');Keyboard.press('TEST'); delay(50); Keyboard.release('KEY_LEFT_CTRL);Keyboard.release('KEY_LEFT_ALT);Keyboard.release('TEST);

Note: Look the last key release, there isn't closing single quote. Note 2 : As you see there is single quotes, but KEY are constants so we MUSN'T use quotes._

capture d ecran 2016-09-28 13 05 57

@DanielShlomo

lowlevl commented 8 years ago

Updated @DanielShlomo @Plazmaz

d4n5h commented 8 years ago
  1. Dude, you are going through arrays like an imbecile. Putting like 4 redundant for-loops to find commands in the arrays, that was one of the ugliest solutions i saw in a while (no pun intended)...
  2. "CTRL ALT TEST" - is not even something that you can/want to do. Please look a bit on what you are trying to do and you will realise it is terribly stupid lol. you want to use keys in combos, not strings.... Maybe you want to do something like that: "CTRL ALT t" or "CTRL ALT SHIFT a" And maybe then - "STRING TEST".
  3. Yes, Unparsed commands are replaced with space because that is basic logic. Parser stumbled on a unrecognised command = Parser didn't understood the command = No command was parsed = Blank space (Do i need to make this simpler for you? lol) You can send the error to the console, but don't make the compiler stop because of one command. And as i said - i've disabled the the console errors, will reimplement it later on.
  4. My page is wider than the screen?? lol! i don't really care... as it's not suppose to be "pretty" or something... Anyway, your html/gui looks like a fart so don't even compare between the two. you can click "CTRL -" once to solve this.
  5. "releaseAll();" is redundant if you release the keys recursively.
  6. Ok i didn't make any documentation, although the code is pretty much self-explanatory. You can basically copy+paste your documentation of you project. You're just being petty, seriously...
  7. REPEAT/REPLAY won't work on combos if you don't put the keys in the combos in one line.
  8. ok, there is a problem with the keys not being constants.
  9. Even with the indentation problem, my compiler is much better than yours... Don't even try to compare...
  10. gonna fix it in a few moments...
lowlevl commented 8 years ago
  1. No comment. 2.What does when it do not recognises command ? "something: command not found", it's basic OMG. xD
  2. Same
  3. The CTRL - ? xD U can't make a good html page :P (Go check what i can do ^^ https://tpe.cak3repo.xyz/)
  4. Why do you want to release key recursively ?
  5. Ok
  6. Hmmm and ?
  7. No comment.
  8. Rage/20. @DanielShlomo
d4n5h commented 8 years ago
  1. I didn't say you can't write HTML, i just said that the GUI was ugly. Not that what i did is a piece of art lol it's just a bit better.. I can't really take credit on the "design" as it's just a few lines of HTML... And anyway, the website in the link you gave doesn't look that good... lol
  2. As i said, there is a need for debugging in console. I didn't said that we don't need to debug at all. i just preferred that compiler won't stop completely... like in Plazmaz's project...
  3. You're correct on that we don't "need" to release the keys recursively. You can add a releaseAll(); after all the keys are pressed... Both solutions will work, it's not that important. but what you did with releaseAll() looks like a mess... You can just add it to the string in the end of the line...
  4. Don't try to find errors in my code like a douchebag... make it better, like i did to yours... As my compiler is better you can just suggest a fix... and i'll add it... Your compiler lacked crucial commands that makes it almost useless if you don't customise/change it heavily.
Plazmaz commented 8 years ago

Alright, going to step in here. Two options for both of you:

  1. I display both projects in the readme.
  2. I add you both as contributors and you can collaborate on the project. Also, please keep it civil.
lowlevl commented 8 years ago

I apologize, i think you can both and allright xD

Plazmaz commented 8 years ago

Either way, I will remove the current notice once this is resolved.

lowlevl commented 8 years ago

Sorry, that kinda immature x) Ok i'll try to help for your project @DanielShlomo.

lowlevl commented 8 years ago

How did arrived here lel x)

Plazmaz commented 8 years ago

@Thecakeisgit Okay so in that case, you want me to put his repo on the front page in place of yours?

lowlevl commented 8 years ago

No both ^^

Plazmaz commented 8 years ago

Alright, is that okay with you @DanielShlomo?

Plazmaz commented 8 years ago

Wait wait wait... His project is a fork of yours... Why not just merge his branch and add him as a contributor?

d4n5h commented 8 years ago

Lets just make one git be better. I don't really care for my credit, as it's not that important to me. Let's just merge everything in your git as it is getting more attention.

lowlevl commented 8 years ago

Because i'm not in accord with some of his changes ^^

d4n5h commented 8 years ago

So fix it and put it on your git.... i'm not stopping you from fixing issues...

lowlevl commented 8 years ago

Ok i'll see ^^ But i prefer if you put issues on my repo ^^ Of what can i change to make the code better, because i like the way i made it ^^ Just i don't understand where my for loops are redundants xD

d4n5h commented 8 years ago

What exactly you don't understand? My code does more with less lines and with less memory being used. Simple.

lowlevl commented 8 years ago

Ok i'll see and fix into my repo :D Alright ?

d4n5h commented 8 years ago

Sure np

lowlevl commented 8 years ago

Ok done @Plazmaz remove this freaking issue x)

d4n5h commented 8 years ago

Here you go, i fixed everything you've pointed out. Fixed indentation. Fixed constants. Even the useless strings in combos "bug" that you found... Now you can do "CTRL ALT TEST" or even "CTRL ALT This is useless"

And i don't care for political correctness. I care for making things better. if my "tone" puts you off then that's your problem. I don't really care. When you contacted me and pointed out issues and fixes for the code i treated you with respect, But when you just listed issues (most of them are non-issue) like a douche, while you could just suggest me fixes i became impatient with you...