Plonq / bevy_panorbit_camera

A simple pan and orbit camera for the Bevy game engine
Apache License 2.0
186 stars 36 forks source link

Jitter with orthographic camera #77

Closed thmxv closed 5 months ago

thmxv commented 5 months ago

Since commit 11b0348bccb1187ed29759cb073330ba73520ec5 (pull request #76) there are jitters when in orthographic camera.

To fix this, the system set does not only need to be before TransformSystem::TransformPropagate but also before CameraUpdateSystem (I think).

Plonq commented 5 months ago

Thanks for the report. I couldn't replicate a jitter, but I did notice a subtle flicker on startup which the above change fixes.

Fix in 0.18.2

thmxv commented 5 months ago

Yes sorry. I did not express myself well.

The jitters are a bit random depending on system ordering and only while zooming an orthographic camera.

The "I think" came because adding the .before(CameraUpdateSystem) fixed the issue for me, but I am not certain this is the correct fix or if it only made the randomness more favorable to me.

Plonq commented 5 months ago

Yeah I assumed it was due to random system ordering :D