search

PlotJuggler / plotjuggler-ros-plugins

Many PlotJuggler plugins for ROS and ROS2.
GNU Affero General Public License v3.0
109 stars 44 forks source link

Compile with rolling #11

Closed doisyg closed 3 years ago

doisyg commented 3 years ago

Bag and executor API breaks with rolling / upcoming galactic. This PR fixes it (though it may be more appropriate to create a new branch ?)

doisyg commented 3 years ago

in order to work with rolling / galactic. See here : https://github.com/facontidavide/PlotJuggler/issues/422

facontidavide commented 3 years ago

Yes, I need to create a different branch. Thanks for contributing. I will try to find time this week to release the packages

doisyg commented 3 years ago

Great! I think there is an issue with the libDataStreamROS2 plugin that I did not take time to test and debug, see https://github.com/facontidavide/PlotJuggler/issues/422 I may take a look at the end of the week if you don't do it before

salmagro commented 3 years ago

Dear @doisyg, I have seen your commits in the rolling branch in this repo, but I am not sure which branch should I use in https://github.com/facontidavide/PlotJuggler.git

I appreciate your comments.