search

PlotJuggler / plotjuggler-ros-plugins

Many PlotJuggler plugins for ROS and ROS2.
GNU Affero General Public License v3.0
109 stars 44 forks source link

Fix compilation on Rolling #60

Closed hodnajit closed 1 year ago

hodnajit commented 1 year ago

After the new release of ros:rolling 7. 1. 2023 the update of the code base is necessary.

facontidavide commented 1 year ago

thanks

facontidavide commented 1 year ago

I think something is missing, I am trying to compile it in Rolling (Docker) and I have the following error:

In file included from /ws_pj/src/plotjuggler-ros-plugins/plugins/TopicPublisherROS2/publisher_ros2.h:18,
                 from /ws_pj/src/plotjuggler-ros-plugins/plugins/TopicPublisherROS2/publisher_ros2.cpp:1:
/ws_pj/src/plotjuggler-ros-plugins/plugins/TopicPublisherROS2/generic_publisher.h: In constructor ‘GenericPublisher::GenericPublisher(rclcpp::node_interfaces::NodeBaseInterface*, const string&, const rosidl_message_type_support_t&)’:
/ws_pj/src/plotjuggler-ros-plugins/plugins/TopicPublisherROS2/generic_publisher.h:28:103: error: ‘event_callbacks_’ was not declared in this scope; did you mean ‘rmw_event_callback_t’?
   28 |     : rclcpp::PublisherBase(node_base, topic_name, type_support, rcl_publisher_get_default_options(), event_callbacks_, true)
      |                                                                                                       ^~~~~~~~~~~~~~~~
      |                                                                                                       rmw_event_callback_t
In file included from /ws_pj/build/plotjuggler_ros/plugins/TopicPublisherROS2_autogen/TH6L5D5FXO/../../../../../src/plotjuggler-ros-plugins/plugins/TopicPublisherROS2/publisher_ros2.h:18,
                 from /ws_pj/build/plotjuggler_ros/plugins/TopicPublisherROS2_autogen/TH6L5D5FXO/moc_publisher_ros2.cpp:10,
                 from /ws_pj/build/plotjuggler_ros/plugins/TopicPublisherROS2_autogen/mocs_compilation.cpp:2:
/ws_pj/build/plotjuggler_ros/plugins/TopicPublisherROS2_autogen/TH6L5D5FXO/../../../../../src/plotjuggler-ros-plugins/plugins/TopicPublisherROS2/generic_publisher.h: In constructor ‘GenericPublisher::GenericPublisher(rclcpp::node_interfaces::NodeBaseInterface*, const string&, const rosidl_message_type_support_t&)’:
/ws_pj/build/plotjuggler_ros/plugins/TopicPublisherROS2_autogen/TH6L5D5FXO/../../../../../src/plotjuggler-ros-plugins/plugins/TopicPublisherROS2/generic_publisher.h:28:103: error: ‘event_callbacks_’ was not declared in this scope; did you mean ‘rmw_event_callback_t’?
   28 |     : rclcpp::PublisherBase(node_base, topic_name, type_support, rcl_publisher_get_default_options(), event_callbacks_, true)
      |                                                                                                       ^~~~~~~~~~~~~~~~
      |                                                                                                       rmw_event_callback_t
gmake[2]: *** [plugins/CMakeFiles/TopicPublisherROS2.dir/build.make:76: plugins/CMakeFiles/TopicPublisherROS2.dir/TopicPublisherROS2_autogen/mocs_compilation.cpp.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[2]: *** [plugins/CMakeFiles/TopicPublisherROS2.dir/build.make:90: plugins/CMakeFiles/TopicPublisherROS2.dir/TopicPublisherROS2/publisher_ros2.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:243: plugins/CMakeFiles/TopicPublisherROS2.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....
gmake: *** [Makefile:146: all] Error 2
---