search

PlotJuggler / plotjuggler-ros-plugins

Many PlotJuggler plugins for ROS and ROS2.
GNU Affero General Public License v3.0
106 stars 44 forks source link

Change `strings_chain` type from `static_vector to `std::vector` in `RosIntrospection::CreateStringFromTreeLeaf()` #75

Closed m2themax closed 9 months ago

m2themax commented 9 months ago

Can we change the type of strings_chain from boost::container::static_vector with fixed length of 16 to std::vector in RosIntrospection::CreateStringFromTreeLeaf(), i.e. here

https://github.com/PlotJuggler/plotjuggler-ros-plugins/blob/e629cd6a1244b4c14402272ea1c04977a9a1b136/plugins/ros1_introspection/src/stringtree_leaf.cpp#L48

The fixed size causes bad_alloc error when loading bags with message depth above 16. With message depth I mean the depth of the tree representing the message type, i.e. the tree represented by leaf in this function.

m2themax commented 9 months ago

Created PR: https://github.com/PlotJuggler/plotjuggler-ros-plugins/pull/76

facontidavide commented 9 months ago

I am refactoring the library completely. Check branch "main".

The ROS parser have been moved here: https://github.com/facontidavide/PlotJuggler/tree/ros_refactored/plotjuggler_plugins/ParserROS

m2themax commented 9 months ago

I am refactoring the library completely. Check branch "main".

The ROS parser have been moved here: https://github.com/facontidavide/PlotJuggler/tree/ros_refactored/plotjuggler_plugins/ParserROS

The bad_alloc problem is fixed on your branch 🥳

Can you estimate when this branch will be merged to main and when the updated version will be available in the apt mirror?

facontidavide commented 9 months ago

done. I have no idea when the APT will be available, it is outside my control