search

PlugaruT / pwned-checker

Simple application for checking if a password is found in Pwned Passwords repository
GNU Lesser General Public License v3.0
10 stars 4 forks source link

Icon Redesign #24

Closed Fatih20 closed 5 years ago

Fatih20 commented 5 years ago

The previous icon didn't comply by eOS HIG regarding the implementation of a pictogram. It should either be extruded or inset. The previous one was just a flat shape. I have also improved the outline that creates the highlight to make it more robust.

PlugaruT commented 5 years ago

Why does the 128px icon have a black line in the top left corner? Also, the border of the icons is not consistent. Some icons have a border of different color. And also, can you keep the original color if the ';--?

Fatih20 commented 5 years ago

Fixed the border issue.

Fatih20 commented 5 years ago

And also, can you keep the original color if the ';--?

But why? Inset effect works best when the shape has a subtle gradient with the lighter color facing the shadow. So, I don't understand why you would want it white. The current one has a color that is already pretty light compared to the base shape so it shouldn't be hard to distinguish between the ':-- and the base shape.

PlugaruT commented 5 years ago

Let's see how it goes. Thanks for your contribution.

Fatih20 commented 5 years ago

You're welcome.

Fatih20 commented 5 years ago

Please credit me in the release note/