search

PlugaruT / wingpanel-monitor

System Monitor Indicator for Wingpanel
GNU General Public License v3.0
75 stars 8 forks source link

Wingpanel 3.0 #25

Closed quequotion closed 3 years ago

quequotion commented 3 years ago

Hello again. Finally got around to trying the new fork, but meson insists on libwingpanel-2.0:

Run-time dependency wingpanel-2.0 found: NO (tried pkgconfig)

meson.build:16:0: ERROR: Dependency "wingpanel-2.0" not found, tried pkgconfig

Edit: Patched around in meson.build, to build against wingpanel 3.0 (which was finally released, btw).

FAILED: libwingpanel-monitor.so.p/src/Indicator.c libwingpanel-monitor.so.p/src/Widgets/DisplayWidget.c libwingpanel-monitor.so.p/src/Widgets/PopoverWidget.c libwingpanel-monitor.so.p/src/Widgets/IndicatorWidget.c libwingpanel-monitor.so.p/src/Widgets/PopoverWidgetRow.c libwingpanel-monitor.so.p/src/Widgets/NetworkWidget.c libwingpanel-monitor.so.p/src/Services/Cpu.c libwingpanel-monitor.so.p/src/Services/Memory.c libwingpanel-monitor.so.p/src/Services/Network.c libwingpanel-monitor.so.p/src/Services/Utils.c libwingpanel-monitor.so.p/src/Services/System.c wingpanel-monitor.h wingpanel-monitor.vapi 
valac -C --debug --debug --vapidir /build/wingpanel-monitor-git/src/wingpanel-monitor/vapi --pkg wingpanel --pkg gdk-x11-3.0 --pkg libgtop-2.0 --pkg gtk+-3.0 --pkg granite --pkg glib-2.0 --pkg gee-0.8 --color=always --directory libwingpanel-monitor.so.p --basedir ../ --library wingpanel-monitor --header wingpanel-monitor.h --vapi ../wingpanel-monitor.vapi --gresources=../data/icons/icons.indicator.gresource.xml ../src/Indicator.vala ../src/Widgets/DisplayWidget.vala ../src/Widgets/PopoverWidget.vala ../src/Widgets/IndicatorWidget.vala ../src/Widgets/PopoverWidgetRow.vala ../src/Widgets/NetworkWidget.vala ../src/Services/Cpu.vala ../src/Services/Memory.vala ../src/Services/Network.vala ../src/Services/Utils.vala ../src/Services/System.vala
../src/Widgets/PopoverWidget.vala:67.22-67.48: warning: `Wingpanel.Widgets.Separator' has been deprecated since 3.0.0. Use Gtk.Separator
../src/Widgets/PopoverWidget.vala:74.22-74.48: warning: `Wingpanel.Widgets.Separator' has been deprecated since 3.0.0. Use Gtk.Separator
../src/Indicator.vala:40.17-40.49: error: Property `display_name' not found in `WingpanelMonitor.Indicator'
                display_name: "Wingpanel-Monitor",
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 1 error(s), 2 warning(s)
[7/25] Compiling Vala source ../src/Application.vala ../src/MainWindow.vala ../src/Widgets/SpinRow.vala ../src/Widgets/Toggles.vala
../src/Widgets/Toggles.vala:24.9-24.51: warning: `Wingpanel.Widgets.Switch' has been deprecated since 3.0.0. Use Granite.SwitchModelButton
../src/Widgets/Toggles.vala:25.9-25.51: warning: `Wingpanel.Widgets.Switch' has been deprecated since 3.0.0. Use Granite.SwitchModelButton
../src/Widgets/Toggles.vala:26.9-26.55: warning: `Wingpanel.Widgets.Switch' has been deprecated since 3.0.0. Use Granite.SwitchModelButton
../src/Widgets/Toggles.vala:27.9-27.57: warning: `Wingpanel.Widgets.Switch' has been deprecated since 3.0.0. Use Granite.SwitchModelButton
../src/Widgets/Toggles.vala:28.9-28.55: warning: `Wingpanel.Widgets.Switch' has been deprecated since 3.0.0. Use Granite.SwitchModelButton
../src/Widgets/Toggles.vala:29.9-29.57: warning: `Wingpanel.Widgets.Switch' has been deprecated since 3.0.0. Use Granite.SwitchModelButton
../src/Widgets/Toggles.vala:30.9-30.50: warning: `Wingpanel.Widgets.Switch' has been deprecated since 3.0.0. Use Granite.SwitchModelButton
../src/Widgets/Toggles.vala:41.36-41.59: warning: `Wingpanel.Widgets.Switch' has been deprecated since 3.0.0. Use Granite.SwitchModelButton
../src/Widgets/Toggles.vala:42.30-42.53: warning: `Wingpanel.Widgets.Switch' has been deprecated since 3.0.0. Use Granite.SwitchModelButton
../src/Widgets/Toggles.vala:43.30-43.53: warning: `Wingpanel.Widgets.Switch' has been deprecated since 3.0.0. Use Granite.SwitchModelButton
../src/Widgets/Toggles.vala:44.34-44.57: warning: `Wingpanel.Widgets.Switch' has been deprecated since 3.0.0. Use Granite.SwitchModelButton
../src/Widgets/Toggles.vala:45.36-45.59: warning: `Wingpanel.Widgets.Switch' has been deprecated since 3.0.0. Use Granite.SwitchModelButton
../src/Widgets/Toggles.vala:48.34-48.57: warning: `Wingpanel.Widgets.Switch' has been deprecated since 3.0.0. Use Granite.SwitchModelButton
../src/Widgets/Toggles.vala:52.29-52.52: warning: `Wingpanel.Widgets.Switch' has been deprecated since 3.0.0. Use Granite.SwitchModelButton
../src/Widgets/Toggles.vala:71.22-71.48: warning: `Wingpanel.Widgets.Separator' has been deprecated since 3.0.0. Use Gtk.Separator
../src/Widgets/Toggles.vala:79.22-79.48: warning: `Wingpanel.Widgets.Separator' has been deprecated since 3.0.0. Use Gtk.Separator
Compilation succeeded - 16 warning(s)
ninja: build stopped: subcommand failed.
andirsun commented 3 years ago

Since elementary Odin is out, rhis is solved now. @PlugaruT please close de issue.

PlugaruT commented 3 years ago

Can you try now, just merged the latest pull request that should have resolved it.

quequotion commented 3 years ago

Confirmed: building against wingpanel 3.0 successful!