Click event are not cancelling in wardrobe

Pattanawaris commented 11 months ago

Terms

[X] I'm using the very latest version of CosmeticsCore and its dependencies.
[X] I already searched on this Github page to check if the same issue was already reported.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already searched on the Discord server to know if anyone already provided a solution in the past for the issue.

Discord tag (optional)

No response

What happened?

When player click to open wardrobe gui the click they perform still remain(ex. Item in player's hand that cast skill by clicking while holding them are casted unintentionally during wardrobe using.)

Steps to reproduce the issue

hold some item that execute something by clicking while holding it and open gui in wardrobe by left clicking.

Server version

Paper-108 (1.20.1)

CosmeticsCore Version

1.2.2g

ProtocolLib Version

5.1.0

LoneLibs Version

1.0.27

FULL server log

No response

Error (optional)

No response

CosmeticsCore config.yml

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

FrancescoJacovo commented 11 months ago

probably it's the same problem that broke our Bedrock compatibilty :(

FrancescoJacovo commented 11 months ago

When they enter the wardrobe see for 1 second the wardrobe gui that will close instantly and never possible to re-open. For java players everything works fine.

LoneDev6 commented 11 months ago

Is your skills plugin using the correct event listener priority? I do cancel my click events.

Pattanawaris commented 11 months ago

Im not sure about that, but its Mmoitems plugin. but I solved it by creating a wardrobe region to prevent skill casting for now.

FrancescoJacovo commented 11 months ago

We didn't added anything betweek cosmetics core and bedrock players while they're in wardrobe, did u changed something in the last versions? It broke with the 1.20 update

FrancescoJacovo commented 11 months ago

(we dont have Mmoitems)

FrancescoJacovo commented 11 months ago

In some of our instance the player can also move around flying

FrancescoJacovo commented 11 months ago

Did u add a method to open specific menu in the API? We can make some workaround

LoneDev6 commented 11 months ago

We didn't added anything betweek cosmetics core and bedrock players while they're in wardrobe, did u changed something in the last versions? It broke with the 1.20 update

No I didn't change anything. Just implemented 1.20+ support.

This is why I never support bedrock compatibility, because it's always unreliable and prone to breaking between updates.

FrancescoJacovo commented 11 months ago

Yeah i know! and for the API method?

FrancescoJacovo commented 11 months ago

Lone?

We didn't added anything betweek cosmetics core and bedrock players while they're in wardrobe, did u changed something in the last versions? It broke with the 1.20 update

No I didn't change anything. Just implemented 1.20+ support.

This is why I never support bedrock compatibility, because it's always unreliable and prone to breaking between updates.

LoneDev6 commented 11 months ago

You should stop asking multiple feature requests / report multiple issues in the same issue page, open a separate one for each single request. Anyway be more specific on what you want to do, what you'd expect to happen and what you need to be added to the API.

LoneDev6 commented 7 months ago

Should be fixed. Changed priority of the event listener to NORMAL.

PluginBugs / Issues-CosmeticsCore