PluginBugs / Issues-CosmeticsCore

Repository used to keep track of issues of my plugin CosmeticsCore
https://lonedev.gitbook.io/cosmeticscore/
0 stars 0 forks source link

Still having difficulty on body cosmetic height #218

Open aaa8881 opened 7 months ago

aaa8881 commented 7 months ago

Terms

Discord tag (optional)

signition

What happened?

still having difficulty to properly set up cosmeticscore to work both in under 1.20.2 and over 1.20.2

server is at 1.20.1 paper

Steps to reproduce the issue

  1. normal_2 , self_2 model are generated, following this guide https://cosmeticscore.devs.beer/files-editor

therefore, I have normal, normal_2, self, self_2 set up0 for cosmetics.

client under 1.20.1 self view outside wardrobe: ✔️ self view in wardrobe: ✔️ view from other: ✔️

client over 1.20.2 self view outside wardrobe: ❌ self view in wardrobe: ✔️ view from other: ✔️

Server version

paper 1.20.1 ( paper #69 )

CosmeticsCore Version

1.2.3d

ProtocolLib Version

v5.1.1

LoneLibs Version

1.0.45

FULL server log

No response

Error (optional)

No response

CosmeticsCore config.yml

lang: en
extract_default_assets: true
cosmetics:
  max_equippable:
    body: 3
    balloon: 2
wardrobe_room:
  camera:
    hide_actionbar_texts: true
    rotation:
      enabled: true
    zoom:
      enabled: true
      min: 2
    fade_effect: true
    location:
      world: flat
      x: 77.74655573982405
      y: -58.37999999523163
      z: 8.150105661412393
      yaw: -0.29977417
      pitch: 2.3999603
  mannequin:
    location:
      world: flat
      x: 77.61714840202833
      y: -60.0
      z: 12.568320756674169
      yaw: 179.85017
      pitch: 16.649956
  teleport_area:
    enter:
      world: flat
      pos1:
        x: 79.0
        y: -61.0
        z: 9.0
      pos2:
        x: 74.0
        y: -58.0
        z: 9.0
    exit_location:
      world: flat
      x: 77.42418689363171
      y: -60.0
      z: 3.5268659258893904
      yaw: -0.29977417
      pitch: 2.3999603
  gui:
    cursor_default: fermented_spider_eye:9000001
    cursor_rotate: fermented_spider_eye:9000002
    cursor_pointer: fermented_spider_eye:9000003
    dyeing_pointer: fermented_spider_eye:9100003
    tutorial_gui: fermented_spider_eye:9100004
    tutorial_gui_checked: fermented_spider_eye:9100005
    slots:
      colors:
        not_owned: 195,147,57
        owned: 56,67,100
        wearing: 57,70,195
        wearing_preview: 195,120,57
        max_amount_reached: 111,111,111
      add_item_in_blank_slots:
        # This is useful only for some expert users that need to do some crazy stuff.
        # Do not enable it if you don't know what you are doing.
        enabled: false
        type: PAPER
        custom_model_data: 1337666
send_creative_hidden_hat_message: true
save:
  # Use only one at a time
  file:
    enabled: true
  mysql:
    enabled: false
    url: jdbc:mysql://my_url_database_69.com:3306/database_name
    username: username
    password: password
    table: cosmeticscore_saved
debug: false

Problematic items yml configuration file (optional)

cutiecatpack_backpack:
    display_name: "냥냥 가방"
    type: BODY_ITEM
    model:
      gui: coal:100123
      normal: coal:100123
      normal_2: coal:100123
      self: coal:100124
      self_2: coal:100124
    dye:
      enabled: false
      default: "#000000"

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

aaa8881 commented 7 months ago

I'm unsure if this is problem of cosmeticscore or blockbench cosmeticscore plugin, but it does not work.

https://imgur.com/a/7tyJPSg

this video shows following information.

  1. self 2 model is generated using cosmeticscore plugin, and it shows correctly in preview mode in blockbench
  2. height issue in game
  3. I changed something in the model and reloaded texturepack to show that current blockbench model is directly using the resourcepack loaded in my computer.
  4. shows model is changed when I change something , save in blockbench
aaa8881 commented 7 months ago

Screenshot_26 Screenshot_27

height is simply fixed at the height of head as it it's hat like this.

ghostaster commented 7 months ago

I'm facing the same issue. Self view gets messed up, but when other players see you, it's at the correct position. Items shows in correct position in GUI and other places except for self view. Kindly resolve this issue.

LoneDev6 commented 7 months ago

Are default example pack cosmetics working correctly? Get them here default_assets.zip

aaa8881 commented 7 months ago

Are default example pack cosmetics working correctly? Get them here default_assets.zip

unfortunately yes. I just drag and dropped that resourcepack and changed custom model data accordingly.

environment (Same): 1.20.1 paper , 1.20.4 client , all plugins latest as stated above.

coal.json

        { "predicate": { "custom_model_data": 102108 }, "model": "cosmetics:body/squirrel_tail_normal_2" },
        { "predicate": { "custom_model_data": 102109 }, "model": "cosmetics:body/squirrel_tail_self_2" },

body.yml

    model:
      gui: coal:102108
      normal: coal:102108
      normal_2: coal:102108
      self: coal:102109
      self_2: coal:102109

Screenshot_31

aaa8881 commented 7 months ago

@LoneDev6 still waiting for it... 😢

LoneDev6 commented 7 months ago

I tested it like 30 times before this issue report and I couldn't reproduce it. I will setup another server and test again.

I'm tempted to just drop 1.20.1 support completely at this point.

aaa8881 commented 7 months ago

I tested it like 30 times before this issue report and I couldn't reproduce it. I will setup another server and test again.

I'm tempted to just drop 1.20.1 support completely at this point.

sorry for that. I will upgrade to 1.20.4 soon after current development but too many things going on atm to fix for 1.20.1 -> 1.20.2+

I will help whatever I can because this is problematic for my server atm. I'll try with more "clean" version server and see if anything fails.

HielkeMaps commented 7 months ago

Can confirm this issue affects me on 1.20.4.

Self view: image

How others see you: image

It used to work just fine, seems to have been broken in an update.

Edit: So I see there are like model_2 and self_2 options now, could this be why it's wrong? I have no idea how to update these though. I don't even use Minecraft < 1.20.4.

happy704 commented 4 months ago

Has this issue not been resolved yet? I'm using paper version 1.20.1 and connecting to versions 1.20.2 and above through the Viaversion plugin. However, the normal_2 feature still isn't working. When I connect to 1.20.1, it shows 'flint', and when I connect to 1.20.2 and above, it also shows 'flint'. Shouldn't charcoal be displayed if normal_2 is functioning correctly?


    enabled: true
    display_name: "천사 날개 3"
    type: BODY_ITEM
    model:
      gui: flint:139
      normal: flint:139
      normal_2: charcoal:139
    dye:
      enabled: false