search

PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
54 stars 21 forks source link

[BUG] server crash #1030

Closed 100petr closed 3 years ago

100petr commented 3 years ago

Describe the bug The server crashes while generating trees (probably) even though you fixed it

To Reproduce I don't know the exact procedure, so I write what I think it is

  1. Go to the end
  2. Fly (probably at the end) and have IA trees generated

Expected behavior The server will not crash

Screenshots If applicable, add screenshots to help explain your problem.

Info (please complete the following information):

Special Info

Additional context Crash: https://pastebin.com/fFPECDR2

LoneDev6 commented 3 years ago

Update to 1.17.1 after I release ItemsAdder 2.4.3. I think it's a 1.17 bug about chunks loading.

You may also try to use Paper

100petr commented 3 years ago

I have been using 1.17.1 since Saturday, but the problem has only occurred once since your fix. before and several times a day (or the players stopped flying so much in the end, before that I restarted them)

LoneDev6 commented 3 years ago

I'd report this to Spigot directly. Seems that somehow the server is calling the populator callback even if the chunk is not loaded in memory. My plugin uses the normal Bukkit populator, no hacky stuff.

I implement this function:

@Override
public void populate(@NotNull World world, @NotNull Random random, @NotNull Chunk source)

What concerns me is that this didn't happen in 1.16.5 at all and I'm using the same code

100petr commented 3 years ago

It was probably a 1.17 bug, the server has been at 1.17.1 for 2 weeks and it hasn't crashed yet.

100petr commented 3 years ago

https://github.com/pl3xgaming/Purpur/commit/6ba5e90c5bea746c5a03f0ccd8f9463d934009be Maybe it's related

LoneDev6 commented 3 years ago

This may be reported also to Spigot itself in order to let them know about the issue. Feel free to open an issue report on their website https://hub.spigotmc.org/jira/projects/SPIGOT/issues