PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
54 stars 21 forks source link

[BUG] ItemsAdder 2.3.12 (Minecraft 1.16.5) doesn't kick when rejecting resourcepack #1113

Closed CristianoBarone closed 3 years ago

CristianoBarone commented 3 years ago

The plugin won't kick players refusing to load the resourcepack

To Reproduce Steps to reproduce the behavior:

  1. Go multiplayer screen
  2. Click on edit server
  3. Select "resorce pack: Prompt"
  4. Enter
  5. Refuse to load resourcepack

Expected behavior Player gets kicked after refusing to load resourcepack

Info

Special Info

Additional context I have no errors in my console, I am running this server as a single paper server on a VPS with 8GB of RAM, I have these plugins installed: AdvancedGUI*, FastAsyncWorldEdit (WorldEdit), ItemsAdder, LibsDisguises, LightAPI, LiteBans, LoneLibs, PlaceholderAPI, ProtocolLib. My config.yml is the following:

metrics: true
update-checker: true
disable-plugin-loading-messages_DONT_ASK_ME_FOR_SUPPORT_IF_YOU_SET_TRUE__THANKS: false
resource-pack:
  self-host:
    enabled: false
    server-ip: 127.0.0.1
    pack-port: 8163
  external-host:
    enabled: true
    url: (My url from dropbox)
  apply-on-join: true
  kick-player-on-decline: true
  kick-player-on-fail: false
  delay-ticks: 1
  notify-other-plugins-interfering: true
  title:
    enabled: true
  protect-player:
    black-screen: true
    hide-hud: true
  custom-font:
    enabled: false
    name: ipaexg.ttf
    shift: '[0,0]'
    size: 11.0
    oversample: 2.0
  thin-font:
    enabled: false
  zip:
    protect-file-from-unzip__DISABLE_IF_ANY_PROBLEM: true
    overwrite-vanilla-models__DISABLE_AT_YOUR_OWN_RISK: true
    overwrite-vanilla-lang-json__DISABLE_AT_YOUR_OWN_RISK: true
    fix_transparent_noteblocks__disable-for-more-performance: false
    ignore-files-ext:
    - db
    - yml
    - xcf
    - html
config_files:
  lang: en
  dictionaries-lang: en
  extract-default-items: true
  extract-default-resources: true
  minify-json: true
blocks:
  light-api: true
  fix-glitched-blocks:
    enabled: true
    only-new-chunks: false
    seach-also-in-these-biomes:
      enabled: false
      biomes:
      - BEACH
      - BIRCH_FOREST
      - BIRCH_FOREST_HILLS
      - FOREST
      - MOUNTAINS
      - MOUNTAIN_EDGE
      - GRAVELLY_MOUNTAINS
      - PLAINS
      - RIVER
  cancel-break-wrong-tool:
    enabled: true
    send-actionbar: true
  campfire:
    unlit-on-place: true
    allow-any-item: true
  disable-REAL-behaviour__DISABLE_AT_YOUR_OWN_RISK: false
  disable-REAL_TRANSPARENT-behaviour__DISABLE_AT_YOUR_OWN_RISK: false
  disable-REAL_NOTE-behaviour__DISABLE_AT_YOUR_OWN_RISK: false
  disable-CUSTOM_FIRE-behaviour: false
items:
  fix-show-attack-and-damage-as-lore: true
  give_death_location_maps: true
  hide-custom-durability-lore: false
liquids:
  enabled: true
huds:
  enabled: true
mobs:
  disable-MOB-behaviour__DISABLE_AT_YOUR_OWN_RISK: false
font_images:
  chat:
    enabled: true
    replace-only-packets: true
    doublecheck-permission__disable-for-more-performance: false
    replace-in-customitems-name-and-lore: true
  command:
    enabled: true
    commandblocks: true
    excluded:
    - home
    - sethome
    - tpa
  sign:
    enabled: true
  book:
    enabled: true
  anvil:
    enabled: true
  inventory-title:
    enabled: true
  tab-header-footer:
    enabled: true
  vault-prefix-suffix:
    enabled: true
    update-every-ticks: 1200
  scoreboard-teams:
    enabled: true
  player-display-name:
    enabled: true
    update-every-ticks: 1200
entities:
  max-furniture-vehicles-per-chunk: 30
debug:
  items:
    log-files-loading: false
    log-items-loading: false
    log-items-loading-disabled: false
    log-font-images-loading: false
    log-huds-loading: false
    log-attribute-modifiers-loading: false
    log-warnings: false
    log-loots-loading: false
    log-loots-loading-disabled: false
  recipes:
    log-recipes-loading: false
    log-recipes-loading-disabled: false
  resource-pack:
    log-extract-default-resources: false
    log-not-extract-default-resources-already-exist: false
  blocks:
    log-save: false
    log-save-on-unload: false
    log-mined-unknown-blocks: true
  worlds-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-generation: false
  trees-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-generation: false
  player-stats:
    log-save: false
  performance:
    loading-ms: true
  huds:
    log-triggers: false
  other:
    log-dictionaries-loading: false
    log-liquids-loading: false
    log-minecraft_lang_overwrite-loading: false
  categories:
    log-total-loaded: true
    log-single-loaded: false
    log-single-loaded-overwrite: false
    log-single-skip: false
LoneDev6 commented 3 years ago

Update the plugin

CristianoBarone commented 3 years ago

Update the plugin

Can't, 2.3.12 is the last version that I got working on 1.16.5

LoneDev6 commented 3 years ago

Latest IA version works fine on 1.16.5. It's the main version I develop the plugin for.

I do all my tests on 1.16.5 and 1.17.1 before release

CristianoBarone commented 3 years ago

Latest IA version works fine on 1.16.5. It's the main version I develop the plugin for.

I do all my tests on 1.16.5 and 1.17.1 before release

https://github.com/PluginBugs/Issues-ItemsAdder/issues/1114 :/

LoneDev6 commented 3 years ago

You have to update LoneLibs