search

PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
53 stars 21 forks source link

water vehicles #1214

Open chimal1994 opened 3 years ago

chimal1994 commented 3 years ago

add the possibility of creating water vehicles (boats, submarines etc)

00Hrtz commented 3 years ago

I so so want this.

OmeWillem commented 2 years ago

Please add this.

LoneDev6 commented 2 years ago

Currently the game sends a "eject" packet to the client each time a player is riding an armorstand in water. This would cause the server to send tons of packets and possibly cause lag.

I need to do some tests but I think this will surely be a laggy feature because of how the game works.

NOTE: this feature cannot be implemented on Minecraft 1.16 because of a bug https://bugs.mojang.com/browse/MC-202202 .

chimal1994 commented 2 years ago

Hello, I just want to comment that I have tried some other plugin that adds water vehicles and they do not generate much lag despite having many armor stands, items adder uses only one per vehicle, so the lag would be even less.

images:

271797312_4868584079864315_352715324809863608_n

271803892_4868584829864240_5513532785208813791_n

LoneDev6 commented 2 years ago

I have to do some tests but this will surely be a 1.17+ only version because of a bug https://bugs.mojang.com/browse/MC-202202 .

myiume commented 2 years ago

+1 on this. I can help with a PR if you need help.

misterquestions commented 2 years ago

Any updates on this?

LoneDev6 commented 2 years ago

This might be implemented in a future update

00Hrtz commented 2 years ago

This might be implemented in a future update

would it not be possible to have the armorstand float on top of the water, in which case it would not cause the dismount issue. I'm personally only interested in an improvement to the already established minecraft boats. While Submarines would be fun it's not something my server will ever need and it's slowing down the chance of having boats implemented.

00Hrtz commented 1 year ago

Also i found out that VOTS addon may be using an Entity like Dolphin, i'm not experienced in Mobs but know the boats in VOTS are not Vehicles, but rather Mob Pets. If it's not possible to have Armorstands float on top of water then maybe you could try with a Mob as a Boat?