[Bug]: CRITICAL! some player can fly when switching world

ArtifactyNight commented 3 years ago

Terms

[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I already searched on this Github page to check if the same issue was already reported.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already asked on the #💬ia-community-help channel on Discord to know if anyone already has a solution for the issue.

Discord tag (optional)

No response

What happened?

Some player can fly when switching world

I'm not sure how it's work but i think it's because of Itemsadder But i already try to remove Itemsadder now it's work fine

some player can fly in nether but cannot fly in spawn and some player can fly in spawn but cannot fly in nether and i see someone cannot fly both (never seen who can fly all world)

Steps to reproduce the issue

Switching the world and see how it's work (it's happened randomly)

Server version

This server is running Purpur version git-Purpur-1394 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: acb8a26 on ver/1.17.1)

ItemsAdder Version

2.4.17

ProtocolLib Version

4.7.0

LoneLibs Version

1.0.14

LightAPI Version (optional)

No response

LibsDisguises Version (optional)

No response

FULL server log

https://mclo.gs/WK70yT9

Error (optional)

None

Configurations

metrics: true
update-checker: true
disable-plugin-loading-messages_DONT_ASK_ME_FOR_SUPPORT_IF_YOU_SET_TRUE__THANKS: false
resource-pack:
  hosting:
    no-host:
      enabled: false
    auto-external-host:
      enabled: false
    self-host:
      enabled: false
      server-ip: 183.88.236.42
      pack-port: 50004
    external-host:
      enabled: false
      url: ''
  apply-on-join: true
  kick-player-on-decline: false
  kick-player-on-fail: false
  delay-ticks: 1
  notify-other-plugins-interfering: true
  title:
    enabled: false
  protect-player:
    black-screen: true
    hide-hud: true
  custom-font:
    enabled: true
    name: thaifix.ttf
    shift: '[-0.5, 1.8]'
    size: 8.8
    oversample: 8.0
  thin-font:
    enabled: false
  zip:
    fix_transparent_noteblocks__disable-for-more-performance: false
    ignore-files-ext:
    - db
    - yml
    - xcf
    - html
    protect-file-from-unzip: true
    overwrite-vanilla-models: true
    overwrite-vanilla-lang-json: true
  items:
    CustomModelData-starting-value:
      ALL: 10000
      DIAMOND: 11000
  command:
    usage-cooldown-seconds: 60
config_files:
  lang: en
  dictionaries-lang: en
  extract-default-items: false
  extract-default-resources: false
  minify-json: true
blocks:
  light-api: true
  fix-glitched-blocks:
    enabled: true
    only-new-chunks: false
    seach-also-in-these-biomes: {}
    search-also-in-these-biomes:
      enabled: false
      biomes:
      - BEACH
      - BIRCH_FOREST
      - BIRCH_FOREST_HILLS
      - FOREST
      - MOUNTAINS
      - MOUNTAIN_EDGE
      - GRAVELLY_MOUNTAINS
      - PLAINS
      - RIVER
  cancel-break-wrong-tool:
    enabled: true
    send-actionbar: true
  campfire:
    unlit-on-place: false
    allow-any-item: false
  disable-REAL: true
  disable-REAL_TRANSPARENT: true
  disable-REAL_NOTE: true
  disable-REAL_WIRE: true
  disable-FIRE: true
items:
  fix-show-attack-and-damage-as-lore: true
  give_death_location_maps: false
  hide-custom-durability-lore: false
liquids:
  enabled: true
huds:
  enabled: true
mobs:
  disable-MOB-behaviour__DISABLE_AT_YOUR_OWN_RISK: false
font_images:
  chat:
    enabled: true
    doublecheck-permission__disable-for-more-performance: false
    replace-in-customitems-name-and-lore: true
    add-hover-suggestion_PAPER_ONLY: true
  command:
    enabled: true
    commandblocks: true
    excluded:
    - home
    - sethome
    - tpa
  sign:
    enabled: true
  book:
    enabled: true
  anvil:
    enabled: true
  inventory-title:
    enabled: true
  tab-header-footer:
    enabled: true
  vault-prefix-suffix:
    enabled: true
    update-every-ticks: 1200
  scoreboard-teams:
    enabled: false
  player-display-name:
    enabled: true
    update-every-ticks: 1200
entities:
  max-furniture-vehicles-per-chunk: 30
  allow-removing-old-furnitures_2_3_11: false
recipes:
  remove-vanilla-recipes:
    enabled: true
    list:
      DIAMOND_SWORD: false
      IRON_INGOT: false
debug:
  items:
    log-files-loading: false
    log-items-loading: false
    log-items-loading-disabled: false
    log-font-images-loading: false
    log-huds-loading: false
    log-attribute-modifiers-loading: false
    log-warnings: false
    log-loots-loading: false
    log-loots-loading-disabled: false
  recipes:
    log-recipes-loading: false
    log-recipes-loading-disabled: false
    log-recipes-removed-vanilla: false
  resource-pack:
    log-extract-default-resources: false
    log-not-extract-default-resources-already-exist: false
  blocks:
    log-save: false
    log-save-on-unload: false
    log-mined-unknown-blocks: true
  worlds-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-loading-no-world: true
    log-generation: false
  trees-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-loading-no-world: true
    log-generation: false
  surface-decorators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-decorators: false
    log-loading-no-world: true
    log-generation: false
  player-stats:
    log-save: false
  performance:
    loading-ms: true
  huds:
    log-triggers: false
  other:
    log-dictionaries-loading: false
    log-liquids-loading: false
    log-minecraft_lang_overwrite-loading: false
  categories:
    log-total-loaded: true
    log-single-loaded: false
    log-single-loaded-overwrite: false
    log-single-skip: false

Screenshots/Videos

None

LoneDev6 commented 3 years ago

ItemsAdder doesn't enable flight for players, this is quite strange

ArtifactyNight commented 3 years ago

maybe it's because change to spectate mode?

ArtifactyNight commented 3 years ago

if this, how can i disable it's will automatically change to gamemode spectate when loading resourcepack?

ArtifactyNight commented 3 years ago

Yes... i tested for a while when i enable resourcepack it's can fly

i need to set hide-hud: false then it's will work fine

videos: https://streamable.com/3bsqz5

LoneDev6 commented 3 years ago

hide-hud: true sets gamemode spectator while applying the resourcepack and freezes the player. The player gamemode is restored back to the original value after the pack loaded (or the player leaves the server while loading).

I think there is a plugin which is saving the player flight permission on join and restores it when you re-enter the world. This causes this bug. In the next update I'll try to bypass this problem, in the meantime make sure to disable hide-hud.

PluginBugs / Issues-ItemsAdder