PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
54 stars 21 forks source link

PlayerJoinEvent lags the server #1274

Closed Xiao-MoMi closed 3 years ago

Xiao-MoMi commented 3 years ago

Terms

Discord tag (optional)

No response

What happened?

image

When player join the server, it creates sudden lags especially when there is many players online.

Steps to reproduce the issue

start the server with ItemsAdder and join the server .

Server version

This server is running Purpur version git-Purpur-1415 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: 2df73e0 on ver/1.17.1)

ItemsAdder Version

[22:02:24 INFO]: ItemsAdder version 2.4.20 [22:02:24 INFO]: Customize Minecraft without client mods! [22:02:24 INFO]: Website: devs.beer [22:02:24 INFO]: Authors: LoneDev and LoneDev

ProtocolLib Version

about ProtocolLib [22:02:36 INFO]: ProtocolLib version 4.7.1-SNAPSHOT-b533 [22:02:36 INFO]: Provides read/write access to the Minecraft protocol. [22:02:36 INFO]: Authors: dmulloy2 and comphenix

LoneLibs Version

about LoneLibs [22:02:46 INFO]: LoneLibs version 1.0.15 [22:02:46 INFO]: Collection of libs used by my plugins [22:02:46 INFO]: Authors: LoneDev and others

LightAPI Version (optional)

No response

LibsDisguises Version (optional)

No response

FULL server log

No response

Error (optional)

No response

Configurations

metrics: true disable-plugin-loading-messages_DONT_ASK_ME_FOR_SUPPORT_IF_YOU_SET_TRUE__THANKS: false resource-pack: apply-on-join: false kick-player-on-decline: false kick-player-on-fail: false delay-ticks: 0 title: enabled: false custom-font: enabled: false name: ipaexg.ttf shift: '[0,0]' size: 11.0 oversample: 2.0 thin-font: enabled: false zip: ignore-files-ext:

Screenshots/Videos

(you can drag and drop files or paste links)

LoneDev6 commented 3 years ago

Does this happen only with 2.4.20?

LoneDev6 commented 3 years ago

Can you please attach the timings report instead of screenshots? It would be helpful, thanks.

Xiao-MoMi commented 3 years ago

https://timings.pl3x.net/?id=14562e70bcbd4209be5b0013ee3ac0be#plugins

Now it's morning in china and i made a 5min timings.It seems that only 1 player joined the server. If needed, I can make another timings at night. This happened since 2.4.15 (Maybe previous versions have the same problem)

LoneDev6 commented 3 years ago

Oh it's an old issue then, I thought it was introduced by 2.4.20.

Do you have a lot of teams in your server? I think a plugin may have created a lot of teams and this caused the lag. I will try to optimize it, but I don't think it's caused by ItemsAdder.

In the meantime you can disable this in config.yml

  scoreboard-teams:
    enabled: false