Material change to Splash_Potion recolors the texture of the item (not an enchant shimmer)

[SkulReaper1916]

Terms

• [X] I'm using the very latest version of ItemsAdder and its dependencies.
• [X] I already searched on this Github page to check if the same issue was already reported.
• [X] I already searched on the plugin wiki to know if a solution is already known.
• [X] I already asked on the #💬ia-community-help channel on Discord to know if anyone already has a solution for the issue.

Discord tag (optional)

SkulReaper #8770

What happened?

When the material of a potion is changed from POTION to SPLASH_POTION the item's texture is completely recolored for some colors.

Attached are several potions I made with custom textures, I need them to be splash potions for our minigame.

The Green vile of death is what the potion is supposed to look like. And the Yellow confusion potion is what that should look like. When both are made into the material SPLASH_POTION they turn purple/pink.

To see what would happen if we flipped the colors I also made a purple vial of death to see if it turned green when the material was SPLASH_POTION... it did not.

The base items for POTION and SPLASH_POTION are the same color. Purple was somehow unaffected by the material change.

Have tested on two servers running ItemsAdder as well as other plugins (different plugins on each server) as well as a local server with no other plugins but the required ProtocolLib and LoneLib.

Additionally while working with the team on discord we tried changing the potion color from white to green and adding a flag to hide potion effects, no change. Also after changing the potion color to green (possibly unrelated, though nothing else at the time was changed) the splash potion item pasted itself over the top of the custom skin.

potion item configs.txt

Steps to reproduce the issue

Create (or use the provided) a green or yellow texture for a potion. create an item using a splash potion and your green/yellow texture. Item in game will be a different color.

green_splash_vial_of_death: permission: myitems resource: material: SPLASH_POTION generate: true textures:

• item/vile_of_death.png specific_properties: potion: type: WATER color: WHITE item_flags:
  • HIDE_POTION_EFFECTS

Server version

One server running: [11:57:02] [Server thread/INFO]: This server is running CraftBukkit version 3234-Spigot-6c1c1b2-422cec0 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT)

Other server (also tested on) running: [09:55:41 INFO]: This server is running Paper version git-Paper-276 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: 1707c10)

ItemsAdder Version

version itemsadder [09:58:06 INFO]: ItemsAdder version 2.4.20 [09:58:06 INFO]: Customize Minecraft without client mods! [09:58:06 INFO]: Website: devs.beer [09:58:06 INFO]: Authors: LoneDev and LoneDev

ProtocolLib Version

[09:58:22 INFO]: ProtocolLib version 4.7.0 [09:58:22 INFO]: Provides read/write access to the Minecraft protocol. [09:58:22 INFO]: Authors: dmulloy2 and comphenix

LoneLibs Version

[09:58:35 INFO]: LoneLibs version 1.0.15 [09:58:35 INFO]: Collection of libs used by my plugins [09:58:35 INFO]: Authors: LoneDev and others

LightAPI Version (optional)

No response

LibsDisguises Version (optional)

No response

FULL server log

Ignore the bits about ZM not being able to add the itemsadder to the loot table.. that is calling completed items that have nothing to do with the splash potion. latest.log

Error (optional)

No response

Configurations

myitems.zip

Screenshots/Videos

[LoneDev6]

i suspect that itemsadder "specific_properties.potion" doesn't take into accout splash potions, I have to check this tomorrow and get back to you.

the layer bug will be fixed too, thanks