PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
52 stars 21 forks source link

Dupe glitch crafting recipes #1290

Closed poityTMK closed 2 years ago

poityTMK commented 2 years ago

Terms

Discord tag (optional)

!poity_TMK#6586

What happened?

Craftings that include a consumable item can duplicate the items included in the crafting

Steps to reproduce the issue

is shown in the attached video (if you close the inventory quickly while clicking to take the crafting result, the items are duplicated)

Server version

This server is running Airplane version git-Airplane-99 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: e68f5c2 on HEAD) You are on the latest version! Previous version: git-Airplane-98 (MC: 1.17.1)

ItemsAdder Version

2.4.20

ProtocolLib Version

4.7.0

LoneLibs Version

1.0.15

LightAPI Version (optional)

No response

LibsDisguises Version (optional)

No response

FULL server log

No response

Error (optional)

No response

ItemsAdder config.yml

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

https://www.dropbox.com/s/ojz52rvi47zemdl/Minecraft_1_17_1_Multiplayer_3rd_party_Server_2021_10_31_09_37_00.mp4?dl=0

LoneDev6 commented 2 years ago

@poityTMK does this only happens on the 2x2 crafting?

poityTMK commented 2 years ago

@LoneDev6 I think the bug also works in the crafting table, some time ago I had a similar bug reported I am attaching videos, sorry for the poor quali

https://user-images.githubusercontent.com/44748641/139866993-f37bdd83-a2a8-4322-97dd-463a45077754.mp4

ty

LoneDev6 commented 2 years ago

Send me your yml file which contains the recipe, the hammer and the ingredients for the recipe, thanks

LoneDev6 commented 2 years ago

I'm trying but I cannot reproduce the issue. Maybe you have a crafting plugin which is interfering with ItemsAdder recipes? https://itemsadder.devs.beer/compatibility-with-other-plugins/not-compatible

2x2 crafting with low ping client:

https://user-images.githubusercontent.com/27242001/139870870-97fa463f-a4d0-42ea-9b54-911102e965fe.mp4

crafting table with high ping client:

https://user-images.githubusercontent.com/27242001/139872035-177e3fae-76b4-423e-a013-75ea16ada0dd.mp4

poityTMK commented 2 years ago

@LoneDev6 Attached you can find all the files plus the photo of the plugin list, all those with 'Areson' in the name do not interfere with the crafting, plus we do not use any plugin that goes to use the crafting table

unfortunately I can't show you the files related to the second video because later I had to remove the possibility to get the nuggets from the crafting

In addition I can assure you that it is not related to the user's ping because more than a dozen people have used these bugs and the items they get are real; I don't know how else to explain 2021-11-02_16 15 52

poityTMK commented 2 years ago

@LoneDev6 Ok, I understand well how to reproduce the problem, it does not center the ping you have (I have tested now with multiple people with different pings)

What you need to do is:

I just tested with plugin default objects on a nearly plugin-free server

Edit: it works the same in the 3x3 crafting, but in this case the tool disappear

LoneDev6 commented 2 years ago

Non trovo "Lingotto di Zinco" tra gli oggetti dei file che mi hai mandato. Se la ricetta utilizza il return items come per la ricetta delle Patate sbucciate allora non riesco a riprodurre il problema, strano

poityTMK commented 2 years ago

@LoneDev6 come ho scritto nel messaggio precedente il bug è riproducibile anche con gli oggetti di deafult come il coltello e la patata, allego il file mancante ingots.zip

poityTMK commented 2 years ago

@LoneDev6 c'è un modo per la quale possa dimostartelo "di persona"?

Scot-Survivor commented 2 years ago

Can confirm this is still happening to this day, ItemsAdder version 3.2.2-beta5 Let me know if you need more information

I don't have to press esc as I do it. This is mainly happening with seeds from crops.

update: I went to run the command /iazip to reload the plugin & it's saying the zip was already loading in process, I think If the zip fails to load, the plugin should disabled. I will update more info & more information tomorrow. At the current time, it's very late for me.

LoneDev6 commented 2 years ago

Provide a log of when " the zip was already loading in process" message appears. I need to get info on what failed to load to help you.

In the future open new bug reports instead of answering old ones, this one is from 2021.

Thanks! Have a nice day