PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
52 stars 21 forks source link

Blocks can be duplicated by using mod “Inventory Profiles Next” #1327

Closed Xiao-MoMi closed 2 years ago

Xiao-MoMi commented 2 years ago

Terms

Discord tag (optional)

No response

What happened?

https://user-images.githubusercontent.com/70987828/142998049-cfd8479c-66c8-4927-9630-a66d2bf27b15.mp4

https://user-images.githubusercontent.com/70987828/142998057-7acb3bc2-7673-4f9d-9872-accaf177919a.mp4

Steps to reproduce the issue

follow the video mod download link https://www.curseforge.com/minecraft/mc-mods/inventory-profiles-next

Server version

[17:16:47 INFO]: Checking version, please wait... [17:16:49 INFO]: This server is running Purpur version git-Purpur-1427 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: 8bb5a93 on ver/1.17.1) [17:16:49 INFO]: You are running the latest version [17:16:49 INFO]: Previous version: git-Purpur-1423 (MC: 1.17.1)

ItemsAdder Version

[17:16:56 INFO]: ItemsAdder version 2.4.22 [17:16:56 INFO]: Customized Minecraft without client mods! [17:16:56 INFO]: Website: devs.beer [17:16:56 INFO]: Author: LoneDev

ProtocolLib Version

about ProtocolLib [17:17:03 INFO]: ProtocolLib version 4.7.1-SNAPSHOT-b533 [17:17:03 INFO]: Provides read/write access to the Minecraft protocol. [17:17:03 INFO]: Authors: dmulloy2 and comphenix

LoneLibs Version

about LoneLibs [17:17:09 INFO]: LoneLibs version 1.0.15 [17:17:09 INFO]: Collection of libs used by my plugins [17:17:09 INFO]: Authors: LoneDev and others

LightAPI Version (optional)

No response

LibsDisguises Version (optional)

No response

FULL server log

No response

Error (optional)

No response

ItemsAdder config.yml

metrics: true
disable-plugin-loading-messages_DONT_ASK_ME_FOR_SUPPORT_IF_YOU_SET_TRUE__THANKS: false
resource-pack:
  apply-on-join: false
  kick-player-on-decline: false
  kick-player-on-fail: false
  delay-ticks: 0
  title:
    enabled: false
  custom-font:
    enabled: false
    name: ipaexg.ttf
    shift: '[0,0]'
    size: 11.0
    oversample: 2.0
  thin-font:
    enabled: false
  zip:
    ignore-files-ext:
    - db
    - yml
    - xcf
    - html
    fix_transparent_noteblocks__disable-for-more-performance: false
    protect-file-from-unzip:
      enabled: false
      extreme: false
    overwrite-vanilla-models: true
    overwrite-vanilla-lang-json: true
    compress-png-files: true
    compress-json-files: true
    generate-custom-armors-textures:
      _: 'Available values: VANILLA_1_17 or OPTIFINE'
      enabled: true
      mode: VANILLA_1_17
  notify-other-plugins-interfering: true
  protect-player:
    black-screen: false
    hide-hud: false
    cancel-movement: true
    lock-player: true
  hosting:
    no-host:
      enabled: false
    auto-external-host:
      enabled: false
    self-host:
      enabled: true
      server-ip: 127.0.0.1
      pack-port: 8163
    external-host:
      enabled: false
      url: ''
  items:
    CustomModelData-starting-value:
      ALL: 10000
      DIAMOND: 11000
  command:
    usage-cooldown-seconds: 60
config_files:
  lang: cn
  dictionaries-lang: en
  extract-default-items: false
  extract-default-resources: false
blocks:
  light-api: false
  fix-glitched-blocks:
    enabled: true
    only-new-chunks: false
    fix-real-blocks-drops-chorus-water-bug__disable-for-more-performance: false
    seach-also-in-these-biomes: {}
    search-also-in-these-biomes:
      enabled: false
      biomes:
      - BEACH
      - BIRCH_FOREST
      - BIRCH_FOREST_HILLS
      - FOREST
      - MOUNTAINS
      - MOUNTAIN_EDGE
      - GRAVELLY_MOUNTAINS
      - PLAINS
      - RIVER
  cancel-break-wrong-tool:
    enabled: true
    send-actionbar: true
  campfire:
    unlit-on-place: true
    allow-any-item: true
  disable-REAL: true
  disable-REAL_TRANSPARENT: false
  disable-REAL_NOTE: false
  disable-REAL_WIRE: false
  disable-FIRE: true
items:
  fix-show-attack-and-damage-as-lore: true
  give_death_location_maps: false
  hide-custom-durability-lore: true
liquids:
  enabled: false
huds:
  enabled: false
font_images:
  chat:
    enabled: true
    replace-only-packets: true
    doublecheck-permission__disable-for-more-performance: false
    add-hover-suggestion: true
  command:
    enabled: true
    commandblocks: true
    excluded:
    - home
    - sethome
    - tpa
  sign:
    enabled: true
  book:
    enabled: true
  anvil:
    enabled: true
  inventory-title:
    enabled: true
  tab-header-footer:
    enabled: true
  vault-prefix-suffix:
    enabled: false
    update-every-ticks: 1200
  scoreboard-teams:
    enabled: false
    update-every-ticks: 3600
  player-display-name:
    enabled: true
    update-every-ticks: 1200
  replace-in-customitems-name-and-lore: true
debug:
  items:
    log-files-loading: false
    log-items-loading: false
    log-items-loading-disabled: false
    log-font-images-loading: false
    log-huds-loading: false
    log-attribute-modifiers-loading: false
    log-warnings: false
    log-loots-loading: false
    log-loots-loading-disabled: false
    log-armors-loading: false
  recipes:
    log-recipes-loading: false
    log-recipes-loading-disabled: false
    log-recipes-removed-vanilla: false
  resource-pack:
    log-extract-default-resources: false
    log-not-extract-default-resources-already-exist: false
  blocks:
    log-save: false
    log-save-on-unload: false
    log-mined-unknown-blocks: true
  worlds-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-generation: false
    log-loading-no-world: true
  trees-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-generation: false
    log-loading-no-world: true
  player-stats:
    log-save: false
  performance:
    loading-ms: true
  huds:
    log-triggers: false
  other:
    log-dictionaries-loading: false
    log-liquids-loading: false
    log-minecraft_lang_overwrite-loading: false
  categories:
    log-total-loaded: true
    log-single-loaded: false
    log-single-loaded-overwrite: false
    log-single-skip: false
  surface-decorators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-decorators: false
    log-generation: false
    log-loading-no-world: true
mobs:
  disable-MOB-behaviour__DISABLE_AT_YOUR_OWN_RISK: false
update-checker: false
entities:
  max-furniture-vehicles-per-chunk: 96
  allow-removing-old-furnitures_2_3_11: false
recipes:
  remove-vanilla-recipes:
    enabled: false
    list:
      DIAMOND_SWORD: false
      IRON_INGOT: false
  hide-vanilla-unrecognized-recipe-errors: true
  custom-recipes:
    unlock:
      all-on-join: false
      on-pickup:
        any: false
        ingredients: true
effects:
  hide-scoreboard-numbers: false
  text-effects:
    enabled: true
    replace-in-customitems-name-and-lore: true
    chat:
      enabled: true
    sign:
      enabled: true
    book:
      enabled: true
    anvil:
      enabled: true

Problematic items yml configuration file (optional)

aquamarine_ore:
    display_name: 冰封矿石
    resource:
      model_id: 4010
      material: NOTE_BLOCK
      generate: true
      textures:
      - block/ore/aquamarine_ore.png
    specific_properties:
      block:
        hardness: 11
        placed_model:
          type: REAL_NOTE
          break_particles: BLOCK
        cancel_drop: true
        break_tools_whitelist:
        - PICKAXE
        - pickaxe
  crystal_ore:
    display_name: 尖晶矿石
    resource:
      model_id: 4011
      material: NOTE_BLOCK
      generate: true
      textures:
      - block/ore/crystal_ore.png
    specific_properties:
      block:
        hardness: 9
        placed_model:
          type: REAL_NOTE
          break_particles: BLOCK
        cancel_drop: true
        break_tools_whitelist:
        - PICKAXE
        - pickaxe

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

LoneDev6 commented 2 years ago

Thanks I will test today

LoneDev6 commented 2 years ago

I cannot reproduce the issue

LoneDev6 commented 2 years ago

Anyway you should avoid using blocks as material, use PAPER instead, it's better and it might be the issue.

LoneDev6 commented 2 years ago
aquamarine_ore:
    display_name: 冰封矿石
    resource:
      model_id: 4010
      material: PAPER

Also note: there is no need to specify a manual model_id itemsadder automatically chose an ID when you first create an item, it's one of the advantages of ItemsAdder, you don't have to worry about remembering IDs.

Xiao-MoMi commented 2 years ago
aquamarine_ore:
    display_name: 冰封矿石
    resource:
      model_id: 4010
      material: PAPER

Also note: there is no need to specify a manual model_id itemsadder automatically chose an ID when you first create an item, it's one of the advantages of ItemsAdder, you don't have to worry about remembering IDs.

I'm using model_id because sometimes I clean caches which may cause items display wrong textures.

Xiao-MoMi commented 2 years ago

I will give paper material a shot. Wait a minute

LoneDev6 commented 2 years ago

I confirm it's related to the NOTE_BLOCK item material. I'll try to fix this problem, it only happens if the item is created using a vanilla block type. PAPER doesn't have this issue

Xiao-MoMi commented 2 years ago

i also try 'stone' material after this happen and the same bug still exist Now i'm trying paper

Xiao-MoMi commented 2 years ago

You're right paper works fine It's vanilla block type's bug Whether it can be fixed or not. It's a must to inform others to avoid using vanilla blocks as material

LoneDev6 commented 2 years ago

What is your Discord username? Are you in the beta testing channel?

LoneDev6 commented 2 years ago

@Xiao-MoMi Send me your Discord name so I can add you to the beta testing channel, download the new version after I will publish it and let me know if the bug is fixed for you :D