PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
53 stars 21 forks source link

Enable Jukebox's custom discs "has_record":"true" #1344

Closed LcyDev closed 2 years ago

LcyDev commented 2 years ago

Terms

Discord tag (optional)

ConaII#1154

Describe the solution you'd like

For example, a normal disc with my texturepack does this: "has_record":"false" image "has_record":"true" (you put a vanilla disc) image

I would like the same for custom discs. It would just update the jukebox state to true, thats all.

"has_record":"false" (you put a custom disc) image

Is your feature request related to a problem?

No.

Describe alternatives you've considered

When playing a customdisc update the jukebox properties. Example, if you start playing a custom disc and you do a /setblock x y z minecraft:jukebox[has_record=true] it just works but i want the plugin to do it automatically without commands.

Additional context

No response

LoneDev6 commented 2 years ago

Sorry I don't understand how ItemsAdder is related to this, you can do it without ItemsAdder, you just have to create a blockstate json file and configure your 2 models (like it's done the your resourcepack you're showing)

LcyDev commented 2 years ago

@LoneDev6 ItemsAdder is the problem. How i'm i supposed to change the texture if using custom discs FROM itemsadder doesn't change the blockstate.

LcyDev commented 2 years ago

If you use F3 on the jukebox and play a custom disc you will see that the blockstate isn't changing to "has_record: true"

LcyDev commented 2 years ago

I know how to do this on vanilla, with normal discs But i want this to work with custom dics that play custom music with itemsadder. And itemsadder just removes the disc from your inv, sends a actionbar "playing ..." and starts spawning note particles on top of the jukebox.

This also removes the disc even if you're in creative mode, and it's not actually stored in the jukebox. But i'm not asking for that, i'm just asking that ItemsAdder changes the jukebox has_record state so i can do that

LoneDev6 commented 2 years ago

Okay now I understand your question. Basically you want ItemsAdder to change the blockstate to has_record if the player uses a custom disc. I will try to do that, thanks for the report.