extra blank line on lore when linked MMOItems Armor to ItemsAdder

Caishangqi commented 2 years ago

Terms

[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I already searched on this Github page to check if the same issue was already reported.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already asked on the #💬ia-community-help channel on Discord to know if anyone already has a solution for the issue.

Discord tag (optional)

Caihuashe#6817

What happened?

When I try to link MMOItems Armor to ItemsAdder (with armor render), the new ItemsAdder Items would add a blank line on lore.

Using the different material but have one blank line on lore

Items Create by MMOItems:
Items Create by ItemsAdder (linked with MMOItems):

There is one extra blank line on the lore, I guess is the ItemsAdder Durability lore.

Steps to reproduce the issue

Create MMOItems armor and set material to leather armor
Create ItemsAdder armor and link to MMOItems items
Open the ItemsAdder config and set hide-custom-durability-lore: true
Get the ItemsAdder Items
There is one blank line on the ItemsAdder item lore

Server version

This server is running Paper version git-Paper-181 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 2121aed) You are 4 version(s) behind Download the new version at: https://papermc.io/downloads Previous version: git-Paper-177 (MC: 1.18.1)

ItemsAdder Version

ItemsAdder version 2.5.5

ProtocolLib Version

ProtocolLib version 4.8.0-SNAPSHOT-b540

LoneLibs Version

LoneLibs version 1.0.16b

LightAPI Version (optional)

No response

LibsDisguises Version (optional)

No response

FULL server log

No response

Error (optional)

No response

ItemsAdder config.yml

metrics: true
update-checker: true
disable-plugin-loading-messages_DONT_ASK_ME_FOR_SUPPORT_IF_YOU_SET_TRUE__THANKS: false
resource-pack:
  hosting:
    no-host:
      enabled: false
    auto-external-host:
      enabled: false
    self-host:
      enabled: true
      server-ip: 127.0.0.1
      pack-port: 8163
    external-host:
      enabled: false
      url: ''
      skip-url-file-type-check___DONT_ASK_HELP_IF_SET_TRUE: false
  apply-on-join: true
  kick-player-on-decline: true
  kick-player-on-fail: true
  delay-ticks: 1
  notify-other-plugins-interfering: true
  title:
    enabled: true
  protect-player:
    black-screen: true
    hide-hud: true
    cancel-movement: true
    lock-player: true
  command:
    usage-cooldown-seconds: 60
  custom-font:
    enabled: false
    name: FZXIANGSU12.ttf
    shift: '[0,0]'
    size: 12.0
    oversample: 2.0
  thin-font:
    enabled: false
  zip:
    protect-file-from-unzip:
      enabled: false
      extreme: false
    compress-png-files: true
    compress-json-files: true
    overwrite-vanilla-models: false
    overwrite-vanilla-lang-json: false
    generate-custom-armors-textures:
      _: 'Available values: VANILLA_1_17 or OPTIFINE'
      enabled: true
      mode: VANILLA_1_17
    fix_transparent_noteblocks__disable-for-more-performance: true
    ignore-files-ext:
    - db
    - yml
    - xcf
    - html
    disable-overwrite-leather-armor-layers-textures: false
  items:
    CustomModelData-starting-value:
      ALL: 10000
      DIAMOND: 11000
config_files:
  lang: en
  dictionaries-lang: en
  extract-default-items: false
  extract-default-resources: false
blocks:
  light-api: true
  fix-glitched-blocks:
    enabled: true
    only-new-chunks: false
    search-also-in-these-biomes:
      enabled: false
      biomes:
      - BEACH
      - BIRCH_FOREST
      - BIRCH_FOREST_HILLS
      - FOREST
      - MOUNTAINS
      - MOUNTAIN_EDGE
      - GRAVELLY_MOUNTAINS
      - PLAINS
      - RIVER
  cancel-break-wrong-tool:
    enabled: true
    send-actionbar: true
  campfire:
    unlit-on-place: true
    allow-any-item: true
  disable-REAL: false
  disable-REAL_TRANSPARENT: false
  disable-REAL_NOTE: false
  disable-REAL_WIRE: false
  disable-FIRE: false
  fix-liquids-flow: true
  fix-floating-blocks: true
items:
  fix-show-attack-and-damage-as-lore: true
  give_death_location_maps: false
  hide-custom-durability-lore: true
liquids:
  enabled: true
huds:
  enabled: true
mobs:
  disable-MOB-behaviour__DISABLE_AT_YOUR_OWN_RISK: false
font_images:
  chat:
    enabled: true
    doublecheck-permission__disable-for-more-performance: false
    add-hover-suggestion: true
  command:
    enabled: true
    commandblocks: true
    excluded:
    - home
    - sethome
    - tpa
  sign:
    enabled: true
  book:
    enabled: true
  anvil:
    enabled: true
  inventory-title:
    enabled: true
  tab-header-footer:
    enabled: true
  vault-prefix-suffix:
    enabled: true
    update-every-ticks: 1200
  scoreboard-teams:
    enabled: false
    update-every-ticks: 3600
  player-display-name:
    enabled: true
    update-every-ticks: 1200
  replace-in-customitems-name-and-lore: true
effects:
  hide-scoreboard-numbers: false
  text-effects:
    enabled: true
    replace-in-customitems-name-and-lore: true
    chat:
      enabled: true
    sign:
      enabled: true
    book:
      enabled: true
    anvil:
      enabled: true
    tab-header-footer:
      enabled: true
entities:
  max-furniture-vehicles-per-chunk: 30
  allow-removing-old-furnitures_2_3_11: false
recipes:
  hide-vanilla-unrecognized-recipe-errors: true
  custom-recipes:
    unlock:
      all-on-join: false
      on-pickup:
        any: false
        ingredients: true
  remove-vanilla-recipes:
    enabled: true
    list:
      DIAMOND_SWORD: false
      IRON_INGOT: false
  fix-packet-too-large-kick: false
debug:
  items:
    log-files-loading: false
    log-items-loading: false
    log-items-loading-disabled: false
    log-font-images-loading: true
    log-huds-loading: false
    log-attribute-modifiers-loading: false
    log-warnings: true
    log-loots-loading: false
    log-loots-loading-disabled: false
    log-armors-loading: false
  recipes:
    log-recipes-loading: false
    log-recipes-loading-disabled: false
    log-recipes-removed-vanilla: false
    log-fix-packet-too-large: false
  resource-pack:
    log-extract-default-resources: false
    log-not-extract-default-resources-already-exist: true
  blocks:
    log-save: false
    log-save-on-unload: false
    log-mined-unknown-blocks: true
  worlds-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-loading-no-world: true
    log-generation: false
  trees-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-loading-no-world: true
    log-generation: false
  surface-decorators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-decorators: false
    log-loading-no-world: true
    log-generation: false
  player-stats:
    log-save: false
  performance:
    loading-ms: true
  huds:
    log-triggers: false
  other:
    log-dictionaries-loading: false
    log-liquids-loading: false
    log-minecraft_lang_overwrite-loading: false
  categories:
    log-total-loaded: true
    log-single-loaded: false
    log-single-loaded-overwrite: false
    log-single-skip: false

Problematic items yml configuration file (optional)

info:
  namespace: equipment
armors_rendering:
  platinum_armor:
    color: "#d60000"
    layer_1: armor/platium/armor/platinum_layer_1
    layer_2: armor/platium/armor/platinum_layer_2
#    emissive_1: armor/platium/armor/platinum_layer_1
#    emissive_2: armor/platium/armor/platinum_layer_2
    use_color: false
#    animation:
#      speed: 24
#      interpolation: true
items:
  platinum_chestplate:
    display_name: platinum chestplate
    permission: equipment
    mmoitem:
      type: armor
      id: platinum_chestplate
    resource:
      model_id: 5001
      generate: true
      textures:
        - armor/platium/item/platinum_chestplate
#    durability:
#      max_custom_durability: 602
    specific_properties:
      armor:
        slot: chest
        custom_armor: platinum_armor

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

Caishangqi commented 2 years ago

If I do not set the max durability of an item in mmoitems GUI MCWRE@QL~8}` C3 %MT 1HK the itemsadder lore would work fine

LoneDev6 commented 2 years ago

Can you send a screenshot of the item without loading the resourcepack? Reject the resourcepack when you join the server

Caishangqi commented 2 years ago

Sure, Generated by ItemsAdder 1QIF_7L1NON VVEP%UF@Z49

Generated by MMOItems XPKAM{VDQH~ PI0XK0 6V Y

LoneDev6 commented 2 years ago

Somehow the dye text is not hidden, can you run /iatag while holding the itemsadder item? It somehow doesn't have hide dye the flag applied.

LoneDev6 commented 2 years ago

I might try something in the next update, I'll send you a new build

PluginBugs / Issues-ItemsAdder